-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix HG4BertCascIntranuke #310
Conversation
Another interesting event, because original list consists of 2 secondaries, which should produced 2 cascade.
|
Taking into account the MEC-event in the previous comment, my suggestion is that in fact there is no problem with |
I agree, the problem is not the presence of There is only one The same goes for the second event you reported. The proton with id 7 does not rescatter and looks like it disappears. Also, the total charge of the system is not correct. You have +5 in the initial state (6 protons in the carbon and one electron) and in the final state the total charge is +4 (5 protons in the Boron and one electron) because somehow the proton is lost. It seems that when more than one particle needs to be propagated, the system will fail giving all sorts of wrong results. |
I agree with you that when more than one particle needs to be propagated, the system will sometimes fail giving all sorts of wrong results. @mroda88, could you suggest an expert in GEANT4, who could give me a consult what is going wrong? |
This commit resolves the problem with |
I made a test by running the following command |
Can you post two events: one with one particle propagated via G4 and one with 2 particles propagated via G4? I think this might give an idea if the mother-daughter relations works now. |
Yes, I will post it a bit later. Right now, could you, please, clarify what do you mean by mother-daughter relation? I am afraid, that the understanding does it work or not depends on the definition. |
One particle propagated:
|
Two particle propagated:
|
It's perfect, thanks! |
You are welcome, @mroda88! |
Following today's Core developer meeting, we are now convinced that this PR does the right thing. Mark input is desired as a cross check. We also identified some additional changes:
|
After the fix, the problematic events now look like:
|
Closing this in favour of #360 |
It seems that I found some mistakes in HG4BertCascIntranuke.cxx related to Issue #305. Anyway I had to add isotope O11 in genie_pdg_table.txt. Although this is a rare event, when there is O11 in the final state, but sometimes it happens. GEANT knows about this isotope. Therefore, there is a need to add in genie_pdg_table.txt rare isotope to avoid errors in the future. Maybe someone knows where does GEANT keep it isotopes data table? We could copy all elements from it to genie_pdg_table.txt.
When I run the comand
gevgen -n 179120 -p 11 -e 2.261 -t 1000060120 --tune G18_10d_00_000 --cross-sections xsec_splines.xml --event-generator-list EM --seed 65539
I have found one a single "problematic" event:1690591989 NOTICE gevgen : [n] <gEvGen.cxx::GenerateEventsAtFixedInitState (336)> : *** Generating event............ 179118
1690591989 NOTICE HG4BertCascIntranuke : [n] <HG4BertCascIntranuke.cxx::SetTrackingRadius (354)> : Setting tracking radius to R = 9.6156
1690591989 NOTICE gevgen : [n] <gEvGen.cxx::GenerateEventsAtFixedInitState (348)> : Generated Event GHEP Record:
Now it seems reasonable, but with one exception: what it does this event special:
two particles: proton and pi- should be scattered by GEANT. However, pi- remains unscattered.
I hope we will discuss it at next Core meeting on the 14 August.