tidy + fix a dict storage issue #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto tidy_and_fix_dict_issue
…nto tidy_and_fix_dict_issue
kejohnso
reviewed
Nov 17, 2023
docsrc/contents/smt.rst
Outdated
| @@ -476,6 +475,7 @@ Comparing GMPEs | |||
| Z1 = -999 | |||
| Z25 = -999 | |||
| up_or_down_dip = 1 # 1 = up-dip, 0 = down-dip | |||
| region = 0 # get region specific z1pt0 and zpt50 ('Global' or 'Japan') | |||
There was a problem hiding this comment.
here and at line 156: should this now be indicating "Global" or "Japan" based on the changes in utils_gmpes.py?
kejohnso
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidied up formatting and fixed a bug in weighted gmm values which only occurs if only the mean of a logic tree is plotted