-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
games create/find_all updated #7
base: develop
Are you sure you want to change the base?
games create/find_all updated #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
LGTM 2222 |
routes/index.js
Outdated
@@ -1,5 +1,6 @@ | |||
import express from "express"; | |||
import apiRoutes from "./api"; | |||
import { gameRoutes } from "../module/games/game.routes"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
불필요한 Import 문장이므로 삭제 부탁드립니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
docker-compose.yaml
mongodb 실행 포트 복구 -
routes/api/index.js
/games
를/game
으로 수정 - 불필요한
import
문장 삭제
리뷰가 늦어서 죄송합니다😅
1, 2번은 기존에 팀원들과 합의된 사항에 맞춰야 하므로 꼭 수정했으면 좋겠어요!
형진님이 작성해주신 reivew 사항을 업데이트 후 커밋하였습니다! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
game create, findall api 를 추가하였습니다.
request : {"name": string, "quizIds": [quizObject]} -> response : { "_id": ObjectId, "name": string, "quizIds": [ObjectId]}-
response : [{"quizIds": [{"id": ObjectId, "quizIds": string, "chooseDesc": [string], "answer": int}],"_id": ObjectId, "name":string}]