Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

games create/find_all updated #7

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

rxdcxdrnine
Copy link

game create, findall api 를 추가하였습니다.

  • post: /api/game/
    request : {"name": string, "quizIds": [quizObject]} -> response : { "_id": ObjectId, "name": string, "quizIds": [ObjectId]}-
  • get: /api/game/
    response : [{"quizIds": [{"id": ObjectId, "quizIds": string, "chooseDesc": [string], "answer": int}],"_id": ObjectId, "name":string}]

@r4k0nb4k0n r4k0nb4k0n requested review from a team, r4k0nb4k0n, gusrb3164 and zeze1004 and removed request for a team February 7, 2021 17:31
@r4k0nb4k0n r4k0nb4k0n added the enhancement New feature or request label Feb 7, 2021
@r4k0nb4k0n r4k0nb4k0n added this to the 필수 REST API milestone Feb 7, 2021
@r4k0nb4k0n r4k0nb4k0n linked an issue Feb 7, 2021 that may be closed by this pull request
2 tasks
Copy link

@gusrb3164 gusrb3164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zeze1004
Copy link

zeze1004 commented Feb 8, 2021

LGTM 2222

routes/index.js Outdated
@@ -1,5 +1,6 @@
import express from "express";
import apiRoutes from "./api";
import { gameRoutes } from "../module/games/game.routes";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

불필요한 Import 문장이므로 삭제 부탁드립니다!

routes/api/index.js Outdated Show resolved Hide resolved
docker-compose.yaml Outdated Show resolved Hide resolved
Copy link
Member

@r4k0nb4k0n r4k0nb4k0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • docker-compose.yaml mongodb 실행 포트 복구
  • routes/api/index.js /games/game으로 수정
  • 불필요한 import 문장 삭제

리뷰가 늦어서 죄송합니다😅
1, 2번은 기존에 팀원들과 합의된 사항에 맞춰야 하므로 꼭 수정했으면 좋겠어요!

@rxdcxdrnine
Copy link
Author

  • docker-compose.yaml mongodb 실행 포트 복구
  • routes/api/index.js /games를 /game으로 수정
  • 불필요한 import 문장 삭제

형진님이 작성해주신 reivew 사항을 업데이트 후 커밋하였습니다!

Copy link
Member

@r4k0nb4k0n r4k0nb4k0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r4k0nb4k0n r4k0nb4k0n changed the base branch from main to develop February 15, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

game Create & ReadAll 구현
4 participants