Skip to content

Conversation

@jgiannuzzi
Copy link
Member

This PR fixes some cmake warnings like:

CMake Warning at build/arm64-osx-debug/vcpkg_installed/arm64-osx/share/unofficial-utf8proc/unofficial-utf8proc-config.cmake:1 (message):
  find_package(unofficial-utf8proc) is deprecated.

  utf8proc provides CMake targets:



    find_package(utf8proc)
    target_link_libraries(main PRIVATE utf8proc::utf8proc)

Call Stack (most recent call first):
  build/vcpkg/scripts/buildsystems/vcpkg.cmake:908 (_find_package)
  cpp/CMakeLists.txt:11 (find_package)
ld: warning: ignoring duplicate libraries: '../vcpkg_installed/arm64-osx/debug/lib/libbrotlicommon.a', '../vcpkg_installed/arm64-osx/debug/lib/libbrotlidec.a', '../vcpkg_installed/arm64-osx/debug/lib/libbrotlienc.a', '../vcpkg_installed/arm64-osx/debug/lib/libsnappy.a'

It also removes Arrow/Parquet's transient dependencies from being referenced directly in cpp/CMakeLists.txt as the arrow port now properly adds them to our build.

@jgiannuzzi jgiannuzzi requested a review from adamreeve December 10, 2025 15:30
Copy link
Contributor

@adamreeve adamreeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @jgiannuzzi!

@jgiannuzzi jgiannuzzi merged commit a7a33e2 into G-Research:master Dec 10, 2025
47 checks passed
@jgiannuzzi jgiannuzzi deleted the fix-cmake-warnings branch December 10, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants