-
Notifications
You must be signed in to change notification settings - Fork 56
Update to .NET 10.0 SDK #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1845c5e
e020b4a
d500f48
740e74f
08ee5ea
ab95700
cbac54a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -284,14 +284,12 @@ public void WriteBatch(ReadOnlySpan<TValue> values) | |
| /// <remarks> | ||
| /// The lengths of <paramref name="defLevels"/> and <paramref name="repLevels"/> must be at least <paramref name="numValues"/>. | ||
| /// </remarks> | ||
| /// <exception cref="ArgumentNullException">Thrown if <paramref name="values"/> is null.</exception> | ||
| /// <exception cref="ArgumentOutOfRangeException">Thrown if <paramref name="numValues"/> is larger | ||
| /// than the length of <paramref name="defLevels"/> or <paramref name="repLevels"/>.</exception> | ||
| public unsafe void WriteBatch(int numValues, ReadOnlySpan<short> defLevels, ReadOnlySpan<short> repLevels, ReadOnlySpan<TValue> values) | ||
| { | ||
| if (values == null) throw new ArgumentNullException(nameof(values)); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✅ |
||
| if (defLevels != null && defLevels.Length < numValues) throw new ArgumentOutOfRangeException(nameof(defLevels), "numValues is larger than length of defLevels"); | ||
| if (repLevels != null && repLevels.Length < numValues) throw new ArgumentOutOfRangeException(nameof(repLevels), "numValues is larger than length of repLevels"); | ||
| if (!defLevels.IsEmpty && defLevels.Length < numValues) throw new ArgumentOutOfRangeException(nameof(defLevels), "numValues is larger than length of defLevels"); | ||
| if (!repLevels.IsEmpty && repLevels.Length < numValues) throw new ArgumentOutOfRangeException(nameof(repLevels), "numValues is larger than length of repLevels"); | ||
|
|
||
| var type = typeof(TValue); | ||
|
|
||
|
|
@@ -363,10 +361,6 @@ public unsafe void WriteBatchSpaced( | |
| int numValues, ReadOnlySpan<short> defLevels, ReadOnlySpan<short> repLevels, | ||
| ReadOnlySpan<byte> validBits, long validBitsOffset, ReadOnlySpan<TValue> values) | ||
| { | ||
| if (values == null) throw new ArgumentNullException(nameof(values)); | ||
| if (defLevels == null) throw new ArgumentNullException(nameof(defLevels)); | ||
| if (repLevels == null) throw new ArgumentNullException(nameof(repLevels)); | ||
| if (validBits == null) throw new ArgumentNullException(nameof(validBits)); | ||
|
Comment on lines
-366
to
-369
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✅ |
||
| //if (values.Length < numValues) throw new ArgumentOutOfRangeException("numValues is larger than length of values"); | ||
| if (defLevels.Length < numValues) throw new ArgumentOutOfRangeException(nameof(defLevels), "numValues is larger than length of defLevels"); | ||
| if (repLevels.Length < numValues) throw new ArgumentOutOfRangeException(nameof(repLevels), "numValues is larger than length of repLevels"); | ||
|
|
||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The PublicAPIAnalyzers in .NET 10.0 required me to move those symbols into the individual framework-dependent
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like it affected anything involving |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,12 @@ | ||
| #nullable enable | ||
| ParquetSharp.ByteArray.ByteArray(System.IntPtr pointer, int length) -> void | ||
| ParquetSharp.FixedLenByteArray.FixedLenByteArray(System.IntPtr pointer) -> void | ||
| ParquetSharp.IO.Buffer.Buffer(System.IntPtr data, long size) -> void | ||
| ParquetSharp.IO.Buffer.Data.get -> System.IntPtr | ||
| ParquetSharp.IO.Buffer.MutableData.get -> System.IntPtr | ||
| ParquetSharp.IO.OutputStream.OutputStream(System.IntPtr handle) -> void | ||
| ParquetSharp.IO.RandomAccessFile.RandomAccessFile(System.IntPtr handle) -> void | ||
| ParquetSharp.LogicalType.LogicalType(System.IntPtr handle) -> void | ||
| ParquetSharp.Schema.Node.Node(System.IntPtr handle) -> void | ||
| readonly ParquetSharp.ByteArray.Pointer -> System.IntPtr | ||
| readonly ParquetSharp.FixedLenByteArray.Pointer -> System.IntPtr |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| #nullable enable | ||
| ParquetSharp.ByteArray.ByteArray(nint pointer, int length) -> void | ||
| ParquetSharp.FixedLenByteArray.FixedLenByteArray(nint pointer) -> void | ||
| ParquetSharp.IO.Buffer.Buffer(nint data, long size) -> void | ||
| ParquetSharp.IO.Buffer.Data.get -> nint | ||
| ParquetSharp.IO.Buffer.MutableData.get -> nint | ||
| ParquetSharp.IO.OutputStream.OutputStream(nint handle) -> void | ||
| ParquetSharp.IO.RandomAccessFile.RandomAccessFile(nint handle) -> void | ||
| ParquetSharp.LogicalType.LogicalType(nint handle) -> void | ||
| ParquetSharp.LogicalTypeFactory.DateAsDateOnly.get -> bool | ||
| ParquetSharp.LogicalTypeFactory.DateAsDateOnly.set -> void | ||
| ParquetSharp.LogicalTypeFactory.TimeAsTimeOnly.get -> bool | ||
| ParquetSharp.LogicalTypeFactory.TimeAsTimeOnly.set -> void | ||
| ParquetSharp.Schema.Node.Node(nint handle) -> void | ||
| readonly ParquetSharp.ByteArray.Pointer -> nint | ||
| readonly ParquetSharp.FixedLenByteArray.Pointer -> nint | ||
| static ParquetSharp.LogicalRead.ConvertDateOnly(System.ReadOnlySpan<int> source, System.ReadOnlySpan<short> defLevels, System.Span<System.DateOnly?> destination, short definedLevel) -> void | ||
| static ParquetSharp.LogicalRead.ConvertDateOnly(System.ReadOnlySpan<int> source, System.Span<System.DateOnly> destination) -> void | ||
| static ParquetSharp.LogicalRead.ConvertHalf(System.ReadOnlySpan<ParquetSharp.FixedLenByteArray> source, System.ReadOnlySpan<short> defLevels, System.Span<System.Half?> destination, short definedLevel) -> void | ||
| static ParquetSharp.LogicalRead.ConvertHalf(System.ReadOnlySpan<ParquetSharp.FixedLenByteArray> source, System.Span<System.Half> destination) -> void | ||
| static ParquetSharp.LogicalRead.ConvertTimeOnlyMicros(System.ReadOnlySpan<long> source, System.ReadOnlySpan<short> defLevels, System.Span<System.TimeOnly?> destination, short definedLevel) -> void | ||
| static ParquetSharp.LogicalRead.ConvertTimeOnlyMicros(System.ReadOnlySpan<long> source, System.Span<System.TimeOnly> destination) -> void | ||
| static ParquetSharp.LogicalRead.ConvertTimeOnlyMillis(System.ReadOnlySpan<int> source, System.ReadOnlySpan<short> defLevels, System.Span<System.TimeOnly?> destination, short definedLevel) -> void | ||
| static ParquetSharp.LogicalRead.ConvertTimeOnlyMillis(System.ReadOnlySpan<int> source, System.Span<System.TimeOnly> destination) -> void | ||
| static ParquetSharp.LogicalRead.ToDateOnly(int source) -> System.DateOnly | ||
| static ParquetSharp.LogicalRead.ToHalf(ParquetSharp.FixedLenByteArray source) -> System.Half | ||
| static ParquetSharp.LogicalRead.ToTimeOnlyMicros(long source) -> System.TimeOnly | ||
| static ParquetSharp.LogicalRead.ToTimeOnlyMillis(int source) -> System.TimeOnly | ||
| static ParquetSharp.LogicalWrite.ConvertDateOnly(System.ReadOnlySpan<System.DateOnly> source, System.Span<int> destination) -> void | ||
| static ParquetSharp.LogicalWrite.ConvertDateOnly(System.ReadOnlySpan<System.DateOnly?> source, System.Span<short> defLevels, System.Span<int> destination, short nullLevel) -> void | ||
| static ParquetSharp.LogicalWrite.ConvertHalf(System.ReadOnlySpan<System.Half> source, System.Span<ParquetSharp.FixedLenByteArray> destination, ParquetSharp.ByteBuffer! byteBuffer) -> void | ||
| static ParquetSharp.LogicalWrite.ConvertHalf(System.ReadOnlySpan<System.Half?> source, System.Span<short> defLevels, System.Span<ParquetSharp.FixedLenByteArray> destination, short nullLevel, ParquetSharp.ByteBuffer! byteBuffer) -> void | ||
| static ParquetSharp.LogicalWrite.ConvertTimeOnlyMicros(System.ReadOnlySpan<System.TimeOnly> source, System.Span<long> destination) -> void | ||
| static ParquetSharp.LogicalWrite.ConvertTimeOnlyMicros(System.ReadOnlySpan<System.TimeOnly?> source, System.Span<short> defLevels, System.Span<long> destination, short nullLevel) -> void | ||
| static ParquetSharp.LogicalWrite.ConvertTimeOnlyMillis(System.ReadOnlySpan<System.TimeOnly> source, System.Span<int> destination) -> void | ||
| static ParquetSharp.LogicalWrite.ConvertTimeOnlyMillis(System.ReadOnlySpan<System.TimeOnly?> source, System.Span<short> defLevels, System.Span<int> destination, short nullLevel) -> void | ||
| static ParquetSharp.LogicalWrite.FromDateOnly(System.DateOnly source) -> int | ||
| static ParquetSharp.LogicalWrite.FromTimeOnlyMicros(System.TimeOnly source) -> long | ||
| static ParquetSharp.LogicalWrite.FromTimeOnlyMillis(System.TimeOnly source) -> int |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| #nullable enable |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,12 @@ | ||
| #nullable enable | ||
| ParquetSharp.ByteArray.ByteArray(System.IntPtr pointer, int length) -> void | ||
| ParquetSharp.FixedLenByteArray.FixedLenByteArray(System.IntPtr pointer) -> void | ||
| ParquetSharp.IO.Buffer.Buffer(System.IntPtr data, long size) -> void | ||
| ParquetSharp.IO.Buffer.Data.get -> System.IntPtr | ||
| ParquetSharp.IO.Buffer.MutableData.get -> System.IntPtr | ||
| ParquetSharp.IO.OutputStream.OutputStream(System.IntPtr handle) -> void | ||
| ParquetSharp.IO.RandomAccessFile.RandomAccessFile(System.IntPtr handle) -> void | ||
| ParquetSharp.LogicalType.LogicalType(System.IntPtr handle) -> void | ||
| ParquetSharp.Schema.Node.Node(System.IntPtr handle) -> void | ||
| readonly ParquetSharp.ByteArray.Pointer -> System.IntPtr | ||
| readonly ParquetSharp.FixedLenByteArray.Pointer -> System.IntPtr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅