Adds openalex client as a default client #555
Open
+2,863
−1,828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
jamesbraza
reviewed
Oct 9, 2024
whitead
reviewed
Oct 9, 2024
jamesbraza
reviewed
Oct 10, 2024
Co-authored-by: James Braza <[email protected]>
jamesbraza
reviewed
Oct 10, 2024
…ove bibtext_mapping with comment, update imports, add comment and example of openalex link
jamesbraza
reviewed
Oct 10, 2024
paperqa/clients/openalex.py
Outdated
| Parsed document details. | ||
| """ | ||
| authors = [ | ||
| authorship.get("raw_author_name") |
There was a problem hiding this comment.
This .get if it returns None, won't the reformat_name blow up?
There was a problem hiding this comment.
you're right -- I was thinking this could never be None so I didn't put much thought into it originally. but it's safer regardless.
Added some safeguards. lmk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** Summary of Changes **