Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding retrying of aembedding if it fails #535

Merged
merged 3 commits into from
Oct 6, 2024
Merged

Adding retrying of aembedding if it fails #535

merged 3 commits into from
Oct 6, 2024

Conversation

jamesbraza
Copy link
Collaborator

I was getting failures with our embeddings, and I realized:

  1. We don't configure LiteLLM's retrying set up
  2. We don't use our Router here

This PR resolves item 1

@jamesbraza jamesbraza added the bug Something isn't working label Oct 6, 2024
@jamesbraza jamesbraza self-assigned this Oct 6, 2024
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 6, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 6, 2024
@jamesbraza jamesbraza merged commit 752d372 into main Oct 6, 2024
5 checks passed
@jamesbraza jamesbraza deleted the retrying-aembedding branch October 6, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mskarlin mskarlin mskarlin approved these changes

@whitead whitead Awaiting requested review from whitead

@nadolskit nadolskit Awaiting requested review from nadolskit

Assignees

@jamesbraza jamesbraza

Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @mskarlin