rich.Progress bar for monitoring index builds
#521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
jamesbraza
commented
Oct 3, 2024
| markup=True, | ||
| show_path=False, | ||
| show_level=False, | ||
| console=Console(force_terminal=True), |
There was a problem hiding this comment.
This Console(force_terminal=True) was leading to the progress bar being refreshed every printout, which re-renders it every print (and blowing up the terminal).
It's unclear why this is here, so I am removing this console=Console(force_terminal=True) part
There was a problem hiding this comment.
No it was not me
jamesbraza
force-pushed
the
logging-progress
branch
2 times, most recently
from
4f0fd15
to
7c84bf0
Compare
jamesbraza
force-pushed
the
logging-progress
branch
from
7c84bf0
to
a58211c
Compare
mskarlin
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last week an index build went on for longer than 12 hours, and I had to stop it because i didn't know how close it was.
This PR adds a
rich.Progressbar, with env var enable/disables, to make index builds slightly more user friendly.