Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving run_ldp_agent to center on RolloutManager #519

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Conversation

jamesbraza
Copy link
Collaborator

  • Moves run_ldp_agent to center on RolloutManager so we can support max steps there too
  • Pulls in latest ldp for __init__.py import shortcuts

@jamesbraza jamesbraza added the enhancement New feature or request label Oct 2, 2024
@jamesbraza jamesbraza self-assigned this Oct 2, 2024
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 2, 2024
Copy link
Contributor

@sidnarayanan sidnarayanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 2, 2024
@jamesbraza jamesbraza merged commit 05d2650 into main Oct 2, 2024
5 checks passed
@jamesbraza jamesbraza deleted the newer-ldp branch October 2, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants