Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting Flutter blog post into a doc #2091

Merged
merged 17 commits into from
Jun 2, 2023
Merged

Converting Flutter blog post into a doc #2091

merged 17 commits into from
Jun 2, 2023

Conversation

vcampitelli
Copy link
Contributor

@vcampitelli vcampitelli commented Apr 14, 2023 •
edited
Loading

Closes FusionAuth/fusionauth-issues#2167

Converting old-ish Flutter blog post into one of our tutorials.

@vcampitelli vcampitelli added the content large piece of content label Apr 14, 2023
@vcampitelli vcampitelli self-assigned this Apr 14, 2023
vcampitelli added a commit that referenced this pull request Apr 14, 2023
@vcampitelli
👔 refs #2091 Adding Flutter to the quick start page
73d549f
vcampitelli added a commit that referenced this pull request Apr 14, 2023
@vcampitelli
📝 refs #2091 Adding note to the old Flutter blog post pointing to the…
a190da1 
… new article
vcampitelli added a commit that referenced this pull request Apr 14, 2023
@vcampitelli
🔨 refs #2091 Updating 'Install FusionAuth' steps in tutorials to remo…
a1d59a5 
…ve `docker-compose.override.yml` and replace `docker-compose` with `docker compose`
vcampitelli added a commit that referenced this pull request Apr 14, 2023
@vcampitelli
📝 refs #2091 Adding links to the Flutter tutorial to navigation
045b321
mooreds
mooreds requested changes Apr 14, 2023
View reviewed changes
site/docs/v1/tech/tutorials/integrate-flutter.md Show resolved Hide resolved
site/docs/v1/tech/tutorials/integrate-flutter.md Outdated Show resolved Hide resolved
site/docs/v1/tech/tutorials/integrate-flutter.md Outdated Show resolved Hide resolved
site/docs/v1/tech/tutorials/integrate-flutter.md Outdated Show resolved Hide resolved
site/docs/v1/tech/tutorials/integrate-flutter.md Outdated Show resolved Hide resolved
site/docs/v1/tech/tutorials/integrate-flutter.md Outdated Show resolved Hide resolved
site/docs/v1/tech/tutorials/integrate-flutter.md Outdated Show resolved Hide resolved
site/docs/v1/tech/tutorials/integrate-flutter.md Outdated Show resolved Hide resolved
site/docs/v1/tech/tutorials/integrate-flutter.md Show resolved Hide resolved
site/docs/v1/tech/tutorials/integrate-flutter.md Show resolved Hide resolved
vcampitelli added a commit that referenced this pull request Apr 18, 2023
@vcampitelli
📝 refs #2091 Fixing Flutter article after review
580041e
vcampitelli added a commit that referenced this pull request Apr 25, 2023
@vcampitelli
📝 refs #2091 More changes on Flutter article
c646776
vcampitelli added a commit that referenced this pull request Apr 27, 2023
@vcampitelli
👔 refs #2091 Adding Flutter to the quick start page
f0726e2
vcampitelli added a commit that referenced this pull request Apr 27, 2023
@vcampitelli
📝 refs #2091 Adding note to the old Flutter blog post pointing to the…
3bf2b1e 
… new article
vcampitelli added a commit that referenced this pull request Apr 27, 2023
@vcampitelli
🔨 refs #2091 Updating 'Install FusionAuth' steps in tutorials to remo…
e4dfc81 
…ve `docker-compose.override.yml` and replace `docker-compose` with `docker compose`
vcampitelli added a commit that referenced this pull request Apr 27, 2023
@vcampitelli
📝 refs #2091 Adding links to the Flutter tutorial to navigation
b6e5bd8
vcampitelli added a commit that referenced this pull request Apr 27, 2023
@vcampitelli
📝 refs #2091 Fixing Flutter article after review
c0028e4
vcampitelli added a commit that referenced this pull request Apr 27, 2023
@vcampitelli
📝 refs #2091 More changes on Flutter article
476b224
vcampitelli added a commit that referenced this pull request May 2, 2023
@vcampitelli
📝 refs #2091 Following changes to articles from #2132
88aa2a1
@vcampitelli vcampitelli mentioned this pull request May 2, 2023
Merged
3 tasks
vcampitelli added a commit that referenced this pull request May 3, 2023
@vcampitelli
📝 refs #2091 Using TypeScript library to set up applications as our D…
1901e38 
…art client isn't working
@vcampitelli vcampitelli requested a review from mooreds May 3, 2023 14:55
mooreds
mooreds requested changes May 5, 2023
View reviewed changes
Copy link
Contributor

@mooreds mooreds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stopped at the app auth installation steps, because we're a number of revisions behind.

We want to upgrade this app to the latest versions of libraries and everything because I'm not sure when we'll touch this again. Might be a year or so.

Can you please make sure you've updated the versions and then I can re-review.

site/_includes/docs/v1/tech/tutorials/_integrate-add-user.liquid Outdated Show resolved Hide resolved
site/_includes/docs/v1/tech/tutorials/_integrate-intro.liquid Outdated Show resolved Hide resolved
site/_includes/docs/v1/tech/tutorials/_integrate-prerequisites.liquid Outdated Show resolved Hide resolved
site/_includes/docs/v1/tech/tutorials/_integrate-prerequisites.liquid Outdated Show resolved Hide resolved
site/docs/v1/tech/tutorials/integrate-flutter.md Outdated Show resolved Hide resolved
site/docs/v1/tech/tutorials/integrate-flutter.md Outdated Show resolved Hide resolved
site/docs/v1/tech/tutorials/integrate-flutter.md Outdated Show resolved Hide resolved
site/docs/v1/tech/tutorials/integrate-flutter.md Outdated Show resolved Hide resolved
site/docs/v1/tech/tutorials/integrate-flutter.md Outdated Show resolved Hide resolved
site/docs/v1/tech/tutorials/integrate-flutter.md Outdated Show resolved Hide resolved
@vcampitelli
Copy link
Contributor Author

@mooreds I have upgraded dependencies in the Flutter example app: FusionAuth/fusionauth-example-flutter-dart#4

We'd need to merge it so the remote include in this article can pick them up.

vcampitelli added a commit that referenced this pull request May 12, 2023
@vcampitelli
👔 refs #2091 Adding Flutter to the quick start page
950beca
vcampitelli added a commit that referenced this pull request May 12, 2023
@vcampitelli
📝 refs #2091 Adding note to the old Flutter blog post pointing to the…
8b7008f 
… new article
vcampitelli added a commit that referenced this pull request May 12, 2023
@vcampitelli
🔨 refs #2091 Updating 'Install FusionAuth' steps in tutorials to remo…
32b7037 
…ve `docker-compose.override.yml` and replace `docker-compose` with `docker compose`
vcampitelli added a commit that referenced this pull request May 12, 2023
@vcampitelli
📝 refs #2091 Adding links to the Flutter tutorial to navigation
5595195
vcampitelli added a commit that referenced this pull request May 12, 2023
@vcampitelli
📝 refs #2091 Fixing Flutter article after review
942c011
vcampitelli added a commit that referenced this pull request May 12, 2023
@vcampitelli
📝 refs #2091 More changes on Flutter article
495ec46
vcampitelli added a commit that referenced this pull request May 12, 2023
@vcampitelli
📝 refs #2091 Following changes to articles from #2132
f381f0a
vcampitelli added a commit that referenced this pull request May 12, 2023
@vcampitelli
📝 refs #2091 Using TypeScript library to set up applications as our D…
c7f549a 
…art client isn't working
vcampitelli added a commit that referenced this pull request May 12, 2023
@vcampitelli
📝 refs #2091 Using .md files instead of .liquid and some other fixes …
feaa9df 
…to the Flutter article
@vcampitelli vcampitelli requested a review from mooreds May 12, 2023 13:16
vcampitelli and others added 12 commits May 12, 2023 11:28
@vcampitelli
✨ Converting Flutter blog post into a doc
a6dff34
@vcampitelli
👔 refs #2091 Adding Flutter to the quick start page
6354091
@vcampitelli
📝 refs #2091 Adding note to the old Flutter blog post pointing to the…
5000744 
… new article
@vcampitelli
🔨 refs #2091 Updating 'Install FusionAuth' steps in tutorials to remo…
c6e1708 
…ve `docker-compose.override.yml` and replace `docker-compose` with `docker compose`
@vcampitelli
📝 refs #2091 Adding links to the Flutter tutorial to navigation
62da8ba
@vcampitelli
📝 refs #2091 Fixing Flutter article after review
492e914
@vcampitelli
✏️ Replacing "Maven" mention with "Ruby" in the Rails article
b4f626b
@vcampitelli
📝 refs #2091 More changes on Flutter article
fbf0619
@vcampitelli
📝 refs #2091 Following changes to articles from #2132
9ade608
@vcampitelli
📝 refs #2091 Using TypeScript library to set up applications as our D…
9ce2b7d 
…art client isn't working
@vcampitelli @mooreds
Apply suggestions from code review
f33e836 
Co-authored-by: Dan Moore <[email protected]>
@vcampitelli
📝 refs #2091 Using .md files instead of .liquid and some other fixes …
db0bc26 
…to the Flutter article
ColinFrick
ColinFrick suggested changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setup.js needs to be updated for the guide.

I used the code from the PR FusionAuth/fusionauth-example-flutter-dart#4

Nitpick: Logout just resets the local login state, but does not really log me out of FusionAuth. ;)

site/docs/v1/tech/tutorials/integrate-flutter.md Show resolved Hide resolved
site/docs/v1/tech/tutorials/integrate-flutter.md Outdated Show resolved Hide resolved
site/docs/v1/tech/tutorials/integrate-flutter.md Show resolved Hide resolved
@vcampitelli vcampitelli mentioned this pull request May 30, 2023
Merged
@vcampitelli
Copy link
Contributor Author

@ColinFrick thanks for the input!

I have opened some PRs in other repositories, so we may encounter some 404 or updated files in this article until they are merged:

ColinFrick
ColinFrick approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change the ngrok link, otherwise LGTM

site/docs/v1/tech/tutorials/integrate-flutter.md Outdated Show resolved Hide resolved
mooreds
mooreds approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@mooreds mooreds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Need to make sure we merge the client-libraries scripts before this is merged, but other than that, looks good. Excited to get this shipped.

@mooreds
Copy link
Contributor

mooreds commented Jun 1, 2023

Ooops, @vcampitelli , you need to merge all the PRs for the example app too, I think.

@vcampitelli vcampitelli merged commit 7c54a09 into master Jun 2, 2023
4 checks passed
@vcampitelli vcampitelli deleted the article/flutter branch June 2, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mooreds mooreds mooreds approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

Assignees

@vcampitelli vcampitelli

Labels
content large piece of content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Touch up Flutter blog post
3 participants
@vcampitelli @mooreds @ColinFrick