Skip to content

Update doc to deal with booleans#11

Closed
mooreds wants to merge 2 commits into
mainfrom
update-doc-to-deal-with-false
Closed

Update doc to deal with booleans#11
mooreds wants to merge 2 commits into
mainfrom
update-doc-to-deal-with-false

Conversation

@mooreds

@mooreds mooreds commented Dec 15, 2020

Copy link
Copy Markdown
Contributor

No description provided.

Working around this rather than fixing it because of future plans to overhaul client libs. If those don't work, should circle back and fix this by modifying client builder freemarker to stringify and lowercase all boolean args.
@mooreds mooreds changed the title Update doc to deal with false Update doc to deal with booleans Dec 15, 2020
@mooreds mooreds mentioned this pull request Dec 15, 2020
@mooreds
mooreds requested a review from robotdan December 15, 2020 17:49
@robotdan

Copy link
Copy Markdown
Contributor

I think we have some helper code for this already.
https://github.com/FusionAuth/fusionauth-client-builder/blob/f6b91bf5e8bda7921a891a7f25ec98fd02dd0fd6/src/main/client/_macros.ftl#L200

Perhaps we just need to use this macro in more places for python code?

@mooreds

mooreds commented Dec 16, 2020

Copy link
Copy Markdown
Contributor Author

I looked at that macro and couldn't figure out how to make it work because what we really want is:

(str(<value>).lower())

which converts True to "true". But I couldn't figure out how to determine, from the inputs to that macro, if a value was a boolean (and also make sure that the global -> _global rename took place as well). Since there was a valid workaround I thought that documentation would be enough.

@mmanes
mmanes deleted the branch main March 6, 2025 17:44
@mmanes mmanes closed this Mar 6, 2025
@johnjeffers
johnjeffers deleted the update-doc-to-deal-with-false branch April 7, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants