Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect mapping for 'char' datatype. #35

Merged
merged 1 commit into from
May 6, 2021

Conversation

mooreds
Copy link
Contributor

@mooreds mooreds commented May 6, 2021

Tested with local example.

This keeps the library from compiling (though the workaround is pretty easy).

Originally surfaced here: FusionAuth/go-client#54

@mooreds mooreds requested a review from a team as a code owner May 6, 2021 16:05
@robotdan
Copy link
Member

robotdan commented May 6, 2021

Looks correct to me

@mooreds
Copy link
Contributor Author

mooreds commented May 6, 2021

@robotdan great, I can't merge though :)

Copy link
Member

@robotdan robotdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve merge

@robotdan
Copy link
Member

robotdan commented May 6, 2021

Try again! :-) I think I approved it correctly this time.

@mooreds mooreds merged commit 4b198f2 into master May 6, 2021
@mooreds mooreds deleted the fix-golang-char-issue branch May 6, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants