Repository navigation
[BUGFIX] Fix STRICT_SYNTAX crashing scripted classes extending other scripts + instantiation via PolymodStaticClassReference.instantiate - #539
Merged
Conversation
nykwono
changed the title
STRICT_SYNTAX] Fix STRICT_SYNTAX crashing scripts that extended other scripts + Always instantiate via PolymodStaticClassReference.instantiateSTRICT_SYNTAX crashing scripted classes extending other scripts + instantiation via PolymodStaticClassReference.instantiate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that made
POLYMOD_STRICT_SYNTAXun-usable for scripts that happen to extend other scripts becausecheckPrivateAccesswould never take into account whether the function in question was called from a scripted superclass rather than the parent class.This also fixes a bug where scripted classes with the same class package or imported would not be properly instantiated. (I did this in another PR but I realized it was really stupid that I did so I'm gonna go back on that change to avoid conflicts)