Fix frame indice numbers for Nene's animations #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hundrec
added
type: minor bug
NotHyper-474
approved these changes
Apr 6, 2025
|
well, this is why |
|
Yeah, separate smaller PRs seem to be easier to handle |
Hundrec
added
pr: art
Hundrec
added
status: reviewing internally
|
Oddly enough, Nene with these changes actually looks off-beat when she bops, and transitions a little more suddenly between her special animations and her idle. |
|
I don't remember what the game even does if you try to play frame number 0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the frame indices in Nene's .json files starting a frame early, causing the timing of her animations to be slightly off.
Note: this issue doesn't affect her hair blowing animations, which aren't currently included in the main branch.
Fixes FunkinCrew/Funkin#4622