[SECURITY VULNERABILITY] Fix ReflectUtil by adding Polymod Blacklist#7005
Merged
Hundrec merged 2 commits intoFunkinCrew:dummy/develop-v0.8.4from Mar 27, 2026
Merged
Conversation
github-actions
Bot
added
status: pending triage
Hundrec
added
the
type: security vulnerability
EliteMasterEric
requested changes
Mar 9, 2026
Member
EliteMasterEric
left a comment
EliteMasterEric
left a comment
There was a problem hiding this comment.
Code for this looks great, but I get several build errors from trying to use it myself!
Contributor
Author
|
Oops, let me fix them asap |
Hundrec
added
status: needs revision
FuroYT
force-pushed
the
security-vuln/fix-reflectutil
branch
from
929d90b to
8f676b6
Compare
Contributor
Author
|
Fixed the errors |
Hundrec
added
status: pending triage
EliteMasterEric
approved these changes
Mar 10, 2026
Member
EliteMasterEric
left a comment
EliteMasterEric
left a comment
There was a problem hiding this comment.
This is a great way of re-implementing this functionality in a way that still prevents vulnerabilities. I like the fact that it automatically pulls from the existing blacklist so we only need to update things once.
FuroYT
force-pushed
the
security-vuln/fix-reflectutil
branch
from
8f676b6 to
75e56b1
Compare
Hundrec
added
status: reviewing internally
Hundrec
added
status: accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
N/A
Description
This fixes a major bug where you could still access blacklisted classes through FlxSave.resolveFlixelClasses with ReflectUtil as it wasn't patched out to block certain fields but this Pull Requests fixes that and along side, it allows new functions onto ReflectUtil which are also protected via the same blacklist and import aliases
New Allowed but protected functions
callMethodcreateEmptyInstancecreateInstanceresolveClassresolveEnumFixed Functions due to accessors and aliases
deleteAnonymousField(fixed accessing fields)getAnonymousField(now uses aliases)getProperty(now uses aliases)hasAnonymousField(now uses aliases)setAnonymousField(fixed accessing fields and using aliases)setProperty(fixed accessing fields and using aliases)Please do intensive testing so bugs doesn't slip through this