[FEATURE/Modding] Add support for the new Polymod mod ID system.#7003
Open
Starexify wants to merge 1 commit intoFunkinCrew:developfrom
Open
[FEATURE/Modding] Add support for the new Polymod mod ID system.#7003Starexify wants to merge 1 commit intoFunkinCrew:developfrom
Starexify wants to merge 1 commit intoFunkinCrew:developfrom
Conversation
Contributor
|
Honorable Mentione |
d3bc0b7 to
f6ba51f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Important
idfield polymod#330Description
This PR updates the
PolymodHandlerto use the newdirNameinstead ofidfor loading mods.Note: This is a breaking change for mods such as the Funkin' Mod Menu if they dont switch to using Dirs and
dirNameinstead of Ids !So let's take this file Tree as example:
The mod "Test" will be the dependency mod for "TestTwo". And its metadata doesn't contain an
id, that means the dependency must be tied to the directory name:But if a user modifies the directory name it will no longer work (check the polymod PR for reasons why).
That's why mods can add a "static" mod ID, which the dependencies could use and work even if the directory name changes:
Note
This doesn't change the old behavior and mods don't need to update to this system immediately !
Screenshots/Videos
POLYMORE.IDs.mp4