[BUGFIX] Fix the instrumental selector being spammable #3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
medium
2 tasks
github-actions
bot
added
haxe
|
si please i need this to be merged so bad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
Fixes #3562
Briefly describe the issue(s) fixed.
CapsuleOptionsMenuhas its own method of handling inputs, independent ofFreeplayState. This, in turn, meant that inputs were still enabled even AFTER selecting a song.This PR adds a Boolean called
busy. This pretty much acts the same as the one inFreeplayState.This is sort of a janky solution, but you can't really do anything much on the Freeplay side since
busyis enabled to preventFreeplayStatefrom accepting inputs while the Instrumental Selector is open (unless you like... made a new boolean to check if the instrumental selector is open or something lol).Something to note
The arrows in the Instrumental Selector (
InstrumentalSelector) can still be controlled, however, this is purely a visual thing.I tried tackling the issue before opening this PR, but I couldn't really figure out a solution without it being a mess.