Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Faster Game Over Mashing (and some cherries on top) #3826

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[ENHANCEMENT] Faster Game Over Mashing (and some cherries on top) #3826

wants to merge 3 commits into from

Conversation

TechnikTil
Copy link
Contributor

About:

This PR adds the ability to skip the confirm sound in GameOverSubState, making it even faster to restart a song. Also, this PR prevents sound effects from colliding into each other, and organizes a little bit.

Video:

yt video cuz its over 10MB

@github-actions github-actions bot added large A large pull request with more than 100 changes haxe Issue/PR modifies game code and removed large A large pull request with more than 100 changes labels Nov 3, 2024
@Hundrec
Copy link
Contributor

Hundrec commented Nov 3, 2024

Ooh, this would address a lot of existing issues!
Can we see a video?

@TechnikTil
Copy link
Contributor Author

TechnikTil commented Nov 3, 2024 •
edited
Loading

Ooh, this would address a lot of existing issues! Can we see a video?

yt video
(i could make one thats less of a joke if you need)

@Hundrec
Copy link
Contributor

Hundrec commented Nov 3, 2024

Oh whoops, missed the link
This video is actually hilarious and gets the point across, love it!

@CrusherNotDrip
Copy link

yt video cuz its over 10MB

https://8mb.video/ unless u dont want it to look a bit poo poo

@CrusherNotDrip
Copy link

also i found this pr because of u posting this on youtube 😭

@TechnikTil
Copy link
Contributor Author

also i found this pr because of u posting this on youtube 😭

lmao

@TechnikTil
Copy link
Contributor Author

ok, i found a bug

if you spam enough in week 6, the pixel fade shader says fuck you and breaks

gonna go fix that rq

@CrusherNotDrip
Copy link

ok, i found a bug
if you spam enough in week 6, the pixel fade shader says fuck you and breaks
gonna go fix that rq

gonna make that a different pr hahahahahpahljifjnbdasjhklfg adshjikubgvads jghkfgasd hgvfkdsghj kmf djghksafkhj gdsf

BOOOO L PR 0/10 I HATE PEOPLE NAMED TECHNIKTIL BOOOO

@TechnikTil
Copy link
Contributor Author

there we go (sorry)

@github-actions github-actions bot added the large A large pull request with more than 100 changes label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hundrec Hundrec Hundrec approved these changes

@CrusherNotDrip CrusherNotDrip CrusherNotDrip approved these changes

@charlesisfeline charlesisfeline charlesisfeline approved these changes

Assignees
No one assigned
Labels
haxe Issue/PR modifies game code large A large pull request with more than 100 changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TechnikTil @Hundrec @CrusherNotDrip @charlesisfeline