Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix early return in hasBeatenSong() #3820

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[BUGFIX] Fix early return in hasBeatenSong() #3820

wants to merge 1 commit into from

Conversation

AbnormalPoof
Copy link
Contributor

@AbnormalPoof AbnormalPoof commented Nov 1, 2024 •
edited
Loading

This PR fixes an early return in hasBeatenSong() and replaces it with continue; instead (since it's a for loop). There's already a return false; below the loop in the event that the song hasn't been beaten.

@github-actions github-actions bot added haxe Issue/PR modifies game code small A small pull request with 10 or fewer changes labels Nov 1, 2024
@EliteMasterEric
Copy link
Member

Technically this only runs if there IS a score and the value is 0, but otherwise this looks correct.

@EliteMasterEric EliteMasterEric added type: minor bug Involves a minor bug or issue. status: reviewing internally This PR is under internal review and quality assurance testing labels Nov 1, 2024
@EliteMasterEric EliteMasterEric self-assigned this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@EliteMasterEric EliteMasterEric

Labels
haxe Issue/PR modifies game code small A small pull request with 10 or fewer changes status: reviewing internally This PR is under internal review and quality assurance testing type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbnormalPoof @EliteMasterEric