[FIX] FreeplayState no longer loads all songs when exiting Erect/Nightmare songs #3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remind me to delete some of my fork branches its getting too crowded
github-actions
bot
added
medium
|
eric i beg of you please give the docs of the develop branch a check i haven't touched them for this pr !!! >:[ |
|
You can always rebase and remove the commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
3664 3706
Briefly describe the issue(s) fixed.
Changes the filter part of
generateSongListfunction to userememberedDifficultyinstead ofcurrentDifficulty.Also makes the
rememberedDifficultyreset when enteringCharSelectSubStatebecause of the case of user having selected Erect/Nightmare and then switching to Pico, who does not have Erect/Nightmare difficulties (as far as we know)Include any relevant screenshots or videos.
2024-10-15.22-25-16.mp4