-
Notifications
You must be signed in to change notification settings - Fork 14
Add a paginated getAuthorWorks function #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gingerchew
wants to merge
20
commits into
FujoWebDev:main
Choose a base branch
from
gingerchew:get-author-works
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the ideal solution is to have a loadUserWorksByPage that can then be extended into a `loadUserWorks` that loops and handles the pagination to generate one big list
I believe the updatedAt might be available on the works list, as there is a date in the top right corner but published at is not available
since there is always a date in the top right corner of the work preview, it will always be a string. An actual work would have a publishedAt and *could* have an updatedAt
Now updatedAt will reflect publishedAt if it has not been updated
Data structure is still a little goofy and doesn't match what was discussed in the discord
currently the function does not automatically paginate, might want to think about changing the name to reflect that Since that is the case, this could be a good time to add in the caching feature, will double check with boba first
still need to get the data parsing to look more like WorkPreview type
Tries to add proper typing to get tests running, but running into an index signature complaint :rolling_eyes: typical typescript hooha
this stops errors in regards to string replaceAll not being supported
This should solve the issues with not being able to do `data[key] = value`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was a little confused if this should go under works or users so I put it under authors for now, obviously we can move it around.
The goal is to add a way to get a list of all works from a user with pagination.