Skip to content

Add a paginated getAuthorWorks function #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

gingerchew
Copy link
Contributor

I was a little confused if this should go under works or users so I put it under authors for now, obviously we can move it around.

The goal is to add a way to get a list of all works from a user with pagination.

getAuthorWorks({ username: 'a string', page: 1 });

I think the ideal solution is to have a loadUserWorksByPage that can then be extended
into a `loadUserWorks` that loops and handles the pagination to generate
one big list
I believe the updatedAt might be available on the works list, as
there is a date in the top right corner
but published at is not available
since there is always a date in the top right corner of the work preview,
it will always be a string.
An actual work would have a publishedAt and *could* have an updatedAt
Now updatedAt will reflect publishedAt if it has not been updated
Data structure is still a little goofy and doesn't match what was discussed in the discord
currently the function does not automatically paginate, might want to think about changing the name to reflect that

Since that is the case, this could be a good time to add in the caching feature, will double check with boba first
still need to get the data parsing to look more like WorkPreview type
Tries to add proper typing to get tests running, but running into an index signature complaint :rolling_eyes:

typical typescript hooha
this stops errors in regards to string replaceAll not being supported
This should solve the issues with not being able to do `data[key] = value`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant