-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script for checking running Monasca health #118
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Dobroslaw Zybort <[email protected]>
To run:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor issue:
In many places, it is written: "...did not returned properly". Pls. correct to "...did not return properly.
For those components that can't be accessed directly: |
The script shall be used by operators. I.e., a README.md is required. |
Signed-off-by: Dobroslaw Zybort <[email protected]>
Signed-off-by: Dobroslaw Zybort <[email protected]>
Some more fixes to script output. Signed-off-by: Dobroslaw Zybort <[email protected]>
Signed-off-by: Dobroslaw Zybort <[email protected]>
Add Kibana check.
Signed-off-by: Dobroslaw Zybort <[email protected]>
Signed-off-by: Dobroslaw Zybort <[email protected]>
Signed-off-by: Dobroslaw Zybort <[email protected]>
Signed-off-by: Dobroslaw Zybort <[email protected]>
Check this number only if user request for it himself, too many false positives that would scare operator. Signed-off-by: Dobroslaw Zybort <[email protected]>
The script currently assumes that docker-compose files are located in a directory two levels above the location of the script. This is certainly a good default, but doesn't fit all situations. |
When executing in an environment that is not OK (not yet tested), I got the following error (see below). Error: |
Signed-off-by: Dobroslaw Zybort <[email protected]>
Done |
Signed-off-by: Dobroslaw Zybort <[email protected]>
Signed-off-by: Dobroslaw Zybort <[email protected]>
Signed-off-by: Dobroslaw Zybort <[email protected]>
As discussed:
|
Pls. add a completion message after completion.
|
Pls. add documentation for "-h" in readme.md |
On a system not properly set up, I called:
2 topics:
|
When specifying -l (log pipeline), only the following services are checked:
However, other central services, like mySql should be checked as well. |
Minor error: |
One more minor issue:
First call: python cmm-check-health.py -f "../.."
Same error is reported for all services. With 2nd call: |
Signed-off-by: Dobroslaw Zybort <[email protected]>
Signed-off-by: Dobroslaw Zybort <[email protected]>
MySql is not used by log pipeline Not sure how I omitted monasca-log-api, looking into this. |
Signed-off-by: Dobroslaw Zybort <[email protected]>
Signed-off-by: Dobroslaw Zybort <[email protected]>
Signed-off-by: Dobroslaw Zybort <[email protected]>
Signed-off-by: Dobroslaw Zybort <[email protected]>
OK, I think that beside completion message everything else is addressed. |
Oh, and checking events for restarts is still not enabled again. |
Signed-off-by: Dobroslaw Zybort <[email protected]>
Checking docker events for restarts enabled again with improved messaging for operator. |
Still missing most Monasca services that don't have proper health check endpoints.
Comments welcome.