Skip to content

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Sep 16, 2025

Description

Continuation of #6860.

The summary of removed todo!() are:
1 - Some todo!() are actually unreachable. In future PRs I will try to model the AST better and remove these match arms;
2 - Some are trivial impls like spans;
3 - Some are trivial from traits like PartialEq and PartialOrd.

Others will be removed in future PRs.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj self-assigned this Sep 16, 2025
Copy link

codspeed-hq bot commented Sep 16, 2025

CodSpeed Performance Report

Merging #7391 will not alter performance

Comparing xunilrj/removing-todo-const-generics (2cf8478) with master (74bab18)

Summary

✅ 25 untouched

@xunilrj xunilrj force-pushed the xunilrj/removing-todo-const-generics branch from 27cbf5a to 8282f12 Compare September 25, 2025 18:33
@xunilrj xunilrj marked this pull request as ready for review September 25, 2025 19:03
@xunilrj xunilrj requested review from a team as code owners September 25, 2025 19:03
IGI-111
IGI-111 previously approved these changes Sep 26, 2025
cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants