-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Removing todo const generics #7391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xunilrj
wants to merge
5
commits into
master
Choose a base branch
from
xunilrj/removing-todo-const-generics
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+254
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #7391 will not alter performanceComparing Summary
|
27cbf5a
to
8282f12
Compare
IGI-111
previously approved these changes
Sep 26, 2025
kmk142789
approved these changes
Sep 28, 2025
JoshuaBatty
reviewed
Sep 29, 2025
ab94b9d
to
b9ceaf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuation of #6860.
The summary of removed
todo!()
are:1 - Some
todo!()
are actually unreachable. In future PRs I will try to model the AST better and remove these match arms;2 - Some are trivial impls like spans;
3 - Some are trivial from traits like
PartialEq
andPartialOrd
.Others will be removed in future PRs.
Checklist
Breaking*
orNew Feature
labels where relevant.