Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: u256 log suggestions #6645

Merged
merged 6 commits into from
Oct 16, 2024
Merged

fix: u256 log suggestions #6645

merged 6 commits into from
Oct 16, 2024

Conversation

K1-R1
Copy link
Member

@K1-R1 K1-R1 commented Oct 16, 2024

Description

u256.log() now always recovers the flag register. Additionally the method now returns 0u256 with invalid args when unsafe math panic is disabled.

Closes #6644

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@K1-R1 K1-R1 self-assigned this Oct 16, 2024
@K1-R1 K1-R1 marked this pull request as ready for review October 16, 2024 08:34
@K1-R1 K1-R1 requested review from a team as code owners October 16, 2024 08:34
@K1-R1 K1-R1 merged commit e216061 into master Oct 16, 2024
38 checks passed
@K1-R1 K1-R1 deleted the k1-r1-f1 branch October 16, 2024 08:55
JoshuaBatty added a commit that referenced this pull request Oct 16, 2024
## Description
waiting on

~~#6645~~
~~#6647~~ 
~~#6649~~ 
~~#6650~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

u256 log(): doesn't recover flag register under all conditions
3 participants