chore: bumped fuels version to 0.98.0
#1766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
65
to
+67
| const isSendingBaseAssetId = useMemo(() => { | ||
| return ( | ||
| assetId && | ||
| provider?.getBaseAssetId().toLowerCase() === assetId.toLowerCase() | ||
| ); | ||
| }, [provider, assetId]); | ||
| return assetId && baseAssetId?.toLowerCase() === assetId.toLowerCase(); | ||
| }, [baseAssetId, assetId]); |
There was a problem hiding this comment.
The getBaseAssetId method is now asynchronous, so I have added as state element and a useEffect to load this.
Wasn't 100% on this change, would be good to validate this.
Comment on lines
-23
to
+20
| return ICON_MAP[OperationName.sent] as Icons; | ||
| return ICON_MAP[OperationName.transfer] as Icons; |
There was a problem hiding this comment.
OperationName.sent has been removed.
OperationName.transfer and OperationName.sent have the same icon, therefore just use OperationName.transfer.
Comment on lines
-317
to
+320
| // We need to forward bech32 addresses to the popup, regardless if we receive a b256 here | ||
| // our database is storing fuel addresses | ||
| const bech32Address = Address.fromDynamicInput(address).toString(); | ||
| const b256Address = Address.fromDynamicInput(address).toString(); | ||
|
|
||
| const signedMessage = await popupService.sendTransaction({ | ||
| address: bech32Address, | ||
| address: b256Address, |
There was a problem hiding this comment.
We have removed the bech32 address.
From this comment, it appears we store bech32 in the database? Would be good to validate this.
|
@petertonysmith94 thank you so much for your work, this will be finished on #1774 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fuelsversion to0.98.0and address all breaking changes.