feat: add ENS resolution and update dependencies #1738
+413
−1,238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xdevcollins
requested review from
LuizAsFight,
arthurgeron,
helciofranco,
luizstacio,
nelitow and
rodrigobranas
as code owners
|
Thanks for the contribution! Before we can merge this, we need @0xdevcollins to sign the Fuel Labs Contributor License Agreement. |
nelitow
reviewed
Dec 22, 2024
| try { | ||
| // Using Ethereum mainnet for ENS resolution | ||
| const provider = new ethers.providers.JsonRpcProvider( | ||
| 'https://mainnet.infura.io/v3/84842078b09946638c03157f83405213' |
There was a problem hiding this comment.
Maybe something like this could be done for the URL
https://github.com/FuelLabs/fuel-explorer-private/blob/feb70258a784e390f5d61f2532666c3fc6fc5322/packages/app-commons/src/config.ts
LuizAsFight
requested changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1647