-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support message types #3016
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedsalk
reviewed
Aug 23, 2024
Torres-ssf
requested review from
digorithm,
Dhaiwat10,
danielbate,
petertonysmith94 and
maschad
as code owners
August 23, 2024 16:23
nedsalk
reviewed
Aug 23, 2024
nedsalk
reviewed
Aug 23, 2024
Torres-ssf
dismissed stale reviews from Dhaiwat10, maschad, and arboleya
via
September 19, 2024 02:50
9aeccc1
Torres-ssf
requested review from
petertonysmith94,
arboleya,
nedsalk,
maschad and
Dhaiwat10
September 19, 2024 02:51
Dhaiwat10
approved these changes
Sep 19, 2024
petertonysmith94
approved these changes
Sep 19, 2024
arboleya
approved these changes
Sep 19, 2024
danielbate
approved these changes
Sep 19, 2024
nedsalk
approved these changes
Sep 19, 2024
Coverage Report:
Changed Files:Coverage values did not change👌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
messagesTypes
for the ABI #2347Summary
This PR corrects the JSON ABI property name by renaming
messagesTypes.message_id
tomessagesTypes.messageId
, which is the correct name within a generated JSO ABI. Theexhaustive-example
contract has also been updated to include a method that generates entries for themessagesTypes
array within its JSON ABI. A new test case has also been added to validate that the property is generated correctly.Checklist