Add expiration policy #871
Conversation
AurelienFT
requested review from
xgreenx,
Dentosal,
MitchTurner and
Voxelot
as code owners
|
We might want to beef up the tests around da_compression.rs to cover policy compression/decompression, as right now it is only testing randomly generated txs without any policies. cc @Dentosal |
Co-authored-by: Andrea Cerone <[email protected]>
fuel-tx/src/transaction/policies.rs
Outdated
| @@ -305,6 +328,11 @@ impl Distribution<Policies> for Standard { | |||
| policies.set(PolicyType::Maturity, Some(maturity as u64)); | |||
| } | |||
|
|
|||
| if policies.get(PolicyType::Expiration).is_some() { | |||
There was a problem hiding this comment.
nit: I think we can use is_set() instead of get(...).is_some()
There was a problem hiding this comment.
Nice. Changed it and for Maturity above also.
| let rng = &mut StdRng::seed_from_u64(2322u64); | ||
|
|
||
| // Given | ||
| const EXPIRATION: BlockHeight = BlockHeight::new(2); |
There was a problem hiding this comment.
| const EXPIRATION: BlockHeight = BlockHeight::new(2); | |
| const EXPIRATION: BlockHeight = BlockHeight::new(1); |
to clearly show that transactions expire only when the current block height is higher than the specified expiry block (if the match, the transaction is still ok).
There was a problem hiding this comment.
For the record, I'd also add a similar test fn transaction__execution__doesn_not_work_after_expiration() and use, for example:
const EXPIRATION: BlockHeight = BlockHeight::new(9);
const BLOCK_HEIGHT: BlockHeight = BlockHeight::new(10);
There was a problem hiding this comment.
I added a new test to test the current height. However it seems that for maturiy we only test correct case here (failed cases are test elsewhere) but I tried to make one here but finalize_checked is panicking on error.
FuelLabs/fuel-specs#593
Spec PR : FuelLabs/fuel-specs#616
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]