Add LDC mode 2, which allows code from memory #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgreenx
reviewed
Oct 6, 2024
| | other | _reserved_ | | ||
|
|
||
| Panic if: | ||
|
|
||
| - `$ssp + $rC` overflows or `> VM_MAX_RAM` | ||
| - `$rA + 32` overflows or `> VM_MAX_RAM` | ||
| - `imm <= 1` and `$rA + 32` overflows or `> VM_MAX_RAM` | ||
| - `$ssp + $rC >= $hp` | ||
| - `imm == 0` and `$rC > CONTRACT_MAX_SIZE` | ||
| - `imm == 0` and contract with ID `MEM[$rA, 32]` is not in `tx.inputs` |
There was a problem hiding this comment.
Do we want to hi light that we return an error if it is called in the context of predicates?
There was a problem hiding this comment.
It's already called out in the predicate section of #612, but we could do that.
Dentosal
commented
Oct 6, 2024
acerone85
reviewed
Oct 6, 2024
Voxelot
reviewed
Oct 7, 2024
Co-authored-by: Brandon Kite <[email protected]>
xgreenx
approved these changes
Oct 10, 2024
Dentosal
added a commit
that referenced
this pull request
Oct 23, 2024
Closes #456 Requires #611 VM PR FuelLabs/fuel-vm#848 ### Before requesting review - [x] I have reviewed the code myself --------- Co-authored-by: Brandon Kite <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VM PR FuelLabs/fuel-vm#849
Before requesting review