Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generation of docker images on release/master push #2631

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

AurelienFT
Copy link
Contributor

Description

Docker Images are useful for our DevOps team. In case of release we should generate them automatically for them and all the users.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@MitchTurner
Copy link
Member

Do we know the history of why this changed?

@AurelienFT AurelienFT added the no changelog Skip the CI check of the changelog modification label Jan 24, 2025
@AurelienFT
Copy link
Contributor Author

Do we know the history of why this changed?

To lower CI times on all branches because it was barely used and increased CI times by 2 for every push.

MitchTurner
MitchTurner previously approved these changes Jan 24, 2025
@AurelienFT AurelienFT changed the title Add generation of docker images on release Add generation of docker images on release/master push Jan 27, 2025
@MitchTurner
Copy link
Member

Is release not good enough? What is the case for having it every PR?

@AurelienFT
Copy link
Contributor Author

Is release not good enough? What is the case for having it every PR?

It's a request from our CTO I think he has more high level vision of who can use it so I trust him on that.

@AurelienFT AurelienFT enabled auto-merge (squash) January 27, 2025 08:22
@AurelienFT AurelienFT requested a review from a team January 27, 2025 08:22
@AurelienFT AurelienFT merged commit 17ed7d3 into master Jan 27, 2025
32 checks passed
@AurelienFT AurelienFT deleted the create_docker_image_for_release branch January 27, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants