Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle new strate transition bytecode and new consensus parameter version #2621

Draft
wants to merge 6 commits into
base: 2552-feature-flag-for-global-state-roots-+-first-onchain-table-implementation
Choose a base branch
from

Conversation

acerone85
Copy link
Contributor

@acerone85 acerone85 commented Jan 22, 2025

on on upgrade transaction

Closes #2584

Questions for the reviewers:

  • I am assuming that the latest known state transition bytecode version and latest known consensus parameters versions will be loaded from the storage when the global root service starts, and will be passed to the proces_block function through the UpdateMerklizedTables trait. Is this reasonable?
  • I am revalidating the upgrade transaction metadata, but I am not sure if this is needed?
  • I am assuming that both state transition bytecode version and consensus parameters version increment by 1 when an upgrade transaction with the corresponding purpose is processed, is this correct?

Linked Issues/PRs

Description

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@acerone85 acerone85 marked this pull request as draft January 22, 2025 19:37
@acerone85 acerone85 self-assigned this Jan 22, 2025
@acerone85 acerone85 added no changelog Skip the CI check of the changelog modification fault-proving labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fault-proving no changelog Skip the CI check of the changelog modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant