Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sign message on keplr and ledger #473

Merged
merged 11 commits into from
Feb 6, 2025
Merged

Conversation

luizstacio
Copy link
Member

@luizstacio luizstacio commented Feb 1, 2025

Summary

Introduce custom encodeTxId methods for different predicate versions in EVM Connectors to fix wallet-specific signing limitations by using UTF-8 encoding.

Also, generates a new predicate to encode transactionId properly when signing.

📷 Connecting Approving a Transfer
connect transfer

Checklist

  • I've added error handling for all actions/requests, and verified how this error will show on UI. (or there was no error handling)
  • I've reviewed all the copy changed/added in this PR, using AI if needed. (or there was no copy changes)
  • I've included the reference to the issues being closed from Github and/or Linear (or there was no issues)
  • I've changed the Docs to reflect my changes (or it was not needed)
  • I've put docs links where it may be helpful (or it was not needed)
  • I checked the resulting UI both in Light and Dark mode (or no UI changes were made)
  • I reviewed the entire PR myself (preferably, on GH UI)

Copy link

vercel bot commented Feb 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuel-connectors ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 9:41pm

Copy link
Contributor

github-actions bot commented Feb 1, 2025

Coverage Report for Fuel Wallet (./packages/fuel-wallet)

Status Category Percentage Covered / Total
🔵 Lines 61.63% 143 / 232
🔵 Statements 61.63% 143 / 232
🔵 Functions 56.66% 17 / 30
🔵 Branches 86.95% 20 / 23
File CoverageNo changed files found.
Generated in workflow #1395 for commit d29778f by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Feb 1, 2025

Coverage Report for Fuel Development Wallet (./packages/fuel-development-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 19 / 19
🔵 Statements 100% 19 / 19
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #1395 for commit d29778f by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Feb 1, 2025

Coverage Report for Fuelet Wallet (./packages/fuelet-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 24 / 24
🔵 Statements 100% 24 / 24
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #1395 for commit d29778f by the Vitest Coverage Report Action

@helciofranco
Copy link
Member

Predicate deployed: 0x3499b76bcb35d8bc68fb2fa74fbe1760461f64f0ac19890c0bacb69377ac19d2
🎉 Deploy completed successfully!

@helciofranco helciofranco merged commit 5f9794e into main Feb 6, 2025
11 checks passed
@helciofranco helciofranco deleted the ls/fix/sign-message branch February 6, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connection not working when using ledger
2 participants