feat: private keys support for testing #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segfault-magnet
requested review from
digorithm,
hal3e,
MujkicA and
Salka1988
as code owners
hal3e
approved these changes
Nov 26, 2024
| @@ -60,7 +60,7 @@ impl WholeStack { | |||
| let db = start_db().await?; | |||
|
|
|||
| let committer = start_committer( | |||
| logs, | |||
| true, | |||
There was a problem hiding this comment.
probably left from debugging
Suggested change
| true, | |
| logs, |
Comment on lines
+152
to
+168
| let blob_signer = if let Some(blob_key) = keys.blob { | ||
| let signer = match blob_key { | ||
| L1Key::Kms(key) => { | ||
| Signer::make_aws_signer(aws_client.as_ref().expect("is set"), key).await? | ||
| } | ||
| L1Key::Private(key) => Signer::make_private_key_signer(&key)?, | ||
| }; | ||
| Some(signer) | ||
| } else { | ||
| None | ||
| }; | ||
|
|
||
| let l1_key = keys.main; | ||
| let main_signer = match l1_key { | ||
| L1Key::Kms(key) => Signer::make_aws_signer(&aws_client.expect("is set"), key).await?, | ||
| L1Key::Private(key) => Signer::make_private_key_signer(&key)?, | ||
| }; |
There was a problem hiding this comment.
is a bit shorter
Suggested change
| let blob_signer = if let Some(blob_key) = keys.blob { | |
| let signer = match blob_key { | |
| L1Key::Kms(key) => { | |
| Signer::make_aws_signer(aws_client.as_ref().expect("is set"), key).await? | |
| } | |
| L1Key::Private(key) => Signer::make_private_key_signer(&key)?, | |
| }; | |
| Some(signer) | |
| } else { | |
| None | |
| }; | |
| let l1_key = keys.main; | |
| let main_signer = match l1_key { | |
| L1Key::Kms(key) => Signer::make_aws_signer(&aws_client.expect("is set"), key).await?, | |
| L1Key::Private(key) => Signer::make_private_key_signer(&key)?, | |
| }; | |
| let blob_signer = match keys.blob { | |
| Some(L1Key::Kms(key)) => { | |
| Some(Signer::make_aws_signer(aws_client.as_ref().expect("is set"), key).await?) | |
| } | |
| Some(L1Key::Private(key)) => Some(Signer::make_private_key_signer(&key)?), | |
| None => None, | |
| }; | |
| let main_signer = match keys.main { | |
| L1Key::Kms(key) => Signer::make_aws_signer(&aws_client.expect("is set"), key).await?, | |
| L1Key::Private(key) => Signer::make_private_key_signer(&key)?, | |
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #160
We'll still be using KMS in our e2e tests so that we remain as close to prod as possible.
The bridge repo can now specify their keys as "Private(key_here)" while we'll configure the keys as "Kms(arn_here)".