-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(UI Pattern): design review fixes #731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an issue that i found: if you change the theme it just takes effect after a reload and not directly
…-blocks into fix/codesandbox-fixes
Unfortunately the only way to fix this is to rerender the whole SandpackProvider, as the Theme Provider is nested inside and it sets an internal state from the theme prop. I have fixed the code accordingly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works now as expected
Task: CU-86933q1m6
Requires guideline-blocks-settings bump
Fixes:
overflow: hidden
.false