Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New content info #216

Merged
merged 7 commits into from
Aug 25, 2024
Merged

New content info #216

merged 7 commits into from
Aug 25, 2024

Conversation

k3ii
Copy link
Contributor

@k3ii k3ii commented Aug 25, 2024

docs(info): add how to become speaker

docs(info): add how to become speaker
Copy link

cloudflare-pages bot commented Aug 25, 2024

Deploying frontend-mu-nuxt with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3e200d2
Status: ✅  Deploy successful!
Preview URL: https://f799f07e.frontend-mu-staging.pages.dev
Branch Preview URL: https://info.frontend-mu-staging.pages.dev

View logs

@k3ii k3ii self-assigned this Aug 25, 2024
@k3ii k3ii requested a review from MrSunshyne August 25, 2024 09:29
@MrSunshyne
Copy link
Member

@k3ii the build is failing because the .md files were moved from /content to /content/info

In the menu there's a link to /history, which is no longer valid because the files were moved. I suggest trying to move them back to /content. Might fix this

@k3ii k3ii added the documentation Improvements or additions to documentation label Aug 25, 2024
@k3ii
Copy link
Contributor Author

k3ii commented Aug 25, 2024

@MrSunshyne it is still failing. It cannot find how-to-become-a-speaker.md and how-to-contribute.md.
Do you know what is missing?

@MrSunshyne
Copy link
Member

@k3ii checks are passing!
The way nuxt generate works, it crawls all the links on our pages and explores all other links and generates their html files.

Since we have not linked to /how-to-contribute anywhere on the website, this will be skipped and not be part of the final bundle. This is why it wasn't generated.

You can make it discoverable by adding it to the menu like we did for the history page.
Bear in my that since this page will now be explored by the compiler, nuxt will try to find every other relative link within this file and pre-render them as well. If there are broken links, it will fail the build.

You can test this locally by running pnpm nuxt generate

I suggest naming the file /contribute instead of /how-to-contribute

@k3ii
Copy link
Contributor Author

k3ii commented Aug 25, 2024

I get this error with nuxt generate:

> ls
README.md            content              public
app.config.ts        eslint.config.mjs    server
app.vue              layouts              store
assets               lib                  styles
auth-utils           nuxt.config.ts       tailwind.config.js
components           package.json         tests
components.json      pages                tsconfig.json
composables          playwright.config.ts utils
> pnpm nuxt generate
 ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL  Command "nuxt" not found

 Also, I added contribute to Menu and it's failing.

@k3ii
Copy link
Contributor Author

k3ii commented Aug 25, 2024

I'm so bad at being a frontend dev xD

@MrSunshyne
Copy link
Member

@k3ii you can run pnpm nuxt generate in the root of the repo, it will run the command in the nuxt package.

i see you're already in the folder, if so, you can simply run pnpm generate and it should be fine!
of course, you should run pnpm install at least once before trying to generate. That's in the docs :P

@k3ii k3ii marked this pull request as ready for review August 25, 2024 19:57
@MrSunshyne MrSunshyne merged commit 36115b0 into main Aug 25, 2024
2 checks passed
Copy link
Member

@MrSunshyne MrSunshyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pages look good! i will modify the content in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants