-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get extension running on TYPO3 11 LTS #39
base: master
Are you sure you want to change the base?
Conversation
Will fix #37 |
The status report widget gives an error in my installation with the next message: So this needs to be fixed too. |
I fixed it. I added the dependency for typo3/cms-reports inside composer.json. In my system, this package was installed so I didn't get this error. Without this package, I got this error. So the status report widget needs the package typo3/cms-reports. @KoenWouters can you check this again? Thanks. |
Makes this extension ready for TYPO3 11 LTS
fde462e
to
e2ecfd9
Compare
It would be nice, if the PR could be merged, so this extension is compatible with TYPO3 v11 LTS and can be used again in our upgraded installations. |
Need to check the added dependency on the report extension. Will try / fix tomorrow and will do a release afterwards. |
@KoenWouters can we expect an approval and a final version for Typo3 11.x? |
@haassie can you take a look at this? |
@haassie @KoenWouters Any updates on this? Would be great to see this FriendsOfTYPO3 extension getting a release for last year's TYPO3 CMS 11 version. |
Hi @RinyVT |
@PhilippKuhlmay Indeed, The only thing I can think of right now is to register these widgets by default, and then check in the widget itself if the extensions are installed. If not, show a message in the widget that the particular extension is missing. |
No, the Services.php is the right way, there can be a check if additional extensions, like reports, are available. |
Not the best solution: A user gets reports extension installed, albeit she/he choose not to use them. So stick to Services.php and check if the extension is installed - and only then register the reports widgets. |
@brotkrueml Ah that sounds better! Hadn't seen that documentation, should be a quick fix then :)
No my idea was not to require reports and seo extensions, but to register the widgets by default. And then, if someone tries to add that widget, it displays a message that the required extension for that widget is not installed. |
I increased the TYPO3 version inside composer.json file