Support for SameSite cookie attribute #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mentalstring
force-pushed
the
samesite-cookies
branch
2 times, most recently
from
374c210 to
b6d8656
Compare
mentalstring
changed the title
thePanz
reviewed
Sep 8, 2025
thePanz
reviewed
Sep 8, 2025
thePanz
reviewed
Sep 8, 2025
mentalstring
force-pushed
the
samesite-cookies
branch
2 times, most recently
from
f224b54 to
a0226e7
Compare
thePanz
reviewed
Sep 11, 2025
mentalstring
force-pushed
the
samesite-cookies
branch
3 times, most recently
from
1383188 to
947302f
Compare
Starting from PHP 7.3 there's native support for SameSite cookies (RFC6265bis) which requires using a new session_get_cookie_params() parameter syntax.
mentalstring
force-pushed
the
samesite-cookies
branch
from
947302f to
584fcf0
Compare
thePanz
approved these changes
Sep 16, 2025
|
Thanks @mentalstring , merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #215.
Since PHP 7.3 there's native support for SameSite cookies (RFC6265bis) which is available by using the newer
session_get_cookie_params(),setcookie()andsetrawcookie()function signatures. This PR enables is use insfWebResponse::setCookie()and insfSessionStorage.The
samesiteparameter is optional, and when not provided (e.g. empty string), PHP simply doesn't use the SameSite cookie attribute, as in previous versions.