Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: inclusion of base test files in composer package (#379) #380

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

vworldat
Copy link
Contributor

See #379

@thePanz
Copy link
Member

thePanz commented Dec 13, 2024

Thanks @vworldat
Should we anchor the other excluded files to the repository root too?

@thePanz thePanz merged commit 7afe4d2 into FriendsOfSymfony1:master Dec 13, 2024
4 checks passed
@vworldat
Copy link
Contributor Author

Thanks @vworldat Should we anchor the other excluded files to the repository root too?

On a personal level, I usually prefer narrow definitions for directory paths because they are most likely to cause false positives. Looking at this project in particular, I'd say perhaps anchor the dirs, but keep the file names as they are. I see no reason to include any of the listed files in a package, unless there was a nested .gitignore that's only used to provide a mandatory empty directory.

@thePanz
Copy link
Member

thePanz commented Dec 13, 2024

Thanks @vworldat for your contribution... and PR!
feel free to open another PR to anchor them if you have time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants