Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update min PHP requirement to v7.4 or v8.1 #325

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Update min PHP requirement to v7.4 or v8.1 #325

merged 2 commits into from
Feb 16, 2024

Conversation

thePanz
Copy link
Member

@thePanz thePanz commented Feb 15, 2024

No description provided.

@thePanz thePanz requested review from thirsch and connorhu February 15, 2024 22:19
connorhu
connorhu reviewed Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@connorhu connorhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not touch .docker files?

@thePanz
Copy link
Member Author

thePanz commented Feb 15, 2024

Do we not touch .docker files?

we did not for doctrine1 FriendsOfSymfony1/doctrine1#122
Maybe a next step? :)

See also:

@thePanz thePanz requested a review from connorhu February 15, 2024 22:36
@connorhu connorhu mentioned this pull request Feb 16, 2024
Open
@thePanz thePanz merged commit 8bc7519 into master Feb 16, 2024
5 checks passed
@thePanz thePanz deleted the require-min-php-74 branch February 16, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorhu connorhu connorhu approved these changes

@thirsch thirsch thirsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thePanz @thirsch @connorhu