Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] added phpstan dist config #312

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

connorhu
Copy link
Collaborator

No description provided.

@connorhu connorhu force-pushed the feature/stanconfig branch 4 times, most recently from 46c3964 to 2711edd Compare January 18, 2024 12:30
@thePanz
Copy link
Member

thePanz commented Mar 20, 2024

@connorhu I added something like this to exclude files not relevant for phpstan

parameters:
    excludePaths:
        analyse:
            - lib/vendor/swiftmailer/
            - lib/task/symfony/lime_symfony.php
            - lib/task/symfony/sfSymfonyTestTask.class.php
            - lib/task/generator/skeleton/
            # Templates for errors
            - lib/exception/data/
            # Templates for classes
            - lib/plugins/sfDoctrinePlugin/data/generator/
            - lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/
            # Templates for application
            - lib/plugins/sfDoctrinePlugin/test/functional/fixtures/apps/

@connorhu connorhu force-pushed the feature/stanconfig branch 3 times, most recently from ffb5e24 to a347c93 Compare March 21, 2024 06:19
@connorhu
Copy link
Collaborator Author

connorhu commented Mar 21, 2024

@thePanz Thank you! Updated the config. Should we do the same as doctrine1? (php7.4 and php8.3 simultan tests)

@connorhu connorhu changed the title add(QA) phpstan dist config [QA] added phpstan dist config Mar 21, 2024
{
}

include 'PEAR/REST/10.php';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 why do we need PEAR?! 🙈

Should we completely drop it? @thirsch IIRC you mentioned something like this?

Copy link
Collaborator Author

@connorhu connorhu Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plugin uses this. i would drop it too as you can see in my plugin loading improvement issue #342 . if only because the default symfony channels don't work. refer to propel discussion

composer.json Outdated
@@ -8,7 +8,8 @@
"friendsofsymfony1/swiftmailer": "^5.4.13 || ^6.2.5"
},
"require-dev": {
"psr/log": "*"
"psr/log": "*",
"friendsofsymfony1/doctrine1": "*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we define the min-versions here?

should swiftmailer be added too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swiftmailer is in required section.
What is the min version should be?

Copy link
Member

@thePanz thePanz Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swiftmailer is in required section

🙈 true 😅
Does it mean that we can remove the GIT submodules then?

What is the min version should be?

I would pick the latest tagged one IMO

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expert on submodule removal is @thirsch . Paging dr @thirsch
#302 (comment)

@connorhu connorhu force-pushed the feature/stanconfig branch from 25bb848 to 7cc334d Compare March 21, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants