Skip to content

Commit

Permalink
[view] fix return statement missing on ParamHolder and CacheManager (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
connorhu authored Mar 21, 2024
1 parent ddc1528 commit d86803d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 4 additions & 2 deletions lib/view/sfViewCacheManager.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -439,9 +439,11 @@ public function remove($internalUri, $hostName = '', $vary = '', $contextualPref
if (strpos($cacheKey, '*')) {
return $this->cache->removePattern($cacheKey);
}
if ($this->cache->has($cacheKey)) {
return $this->cache->remove($cacheKey);
if (!$this->cache->has($cacheKey)) {
return true;
}

return $this->cache->remove($cacheKey);
}

/**
Expand Down
2 changes: 2 additions & 0 deletions lib/view/sfViewParameterHolder.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ public function initialize(sfEventDispatcher $dispatcher, $parameters = [], $opt

$this->setEscaping(isset($options['escaping_strategy']) ? $options['escaping_strategy'] : false);
$this->setEscapingMethod(isset($options['escaping_method']) ? $options['escaping_method'] : 'ESC_SPECIALCHARS');

return true;
}

/**
Expand Down

0 comments on commit d86803d

Please sign in to comment.