[view] fix return statement missing on ParamHolder and CacheManager (#…

…350)
FriendsOfSymfony1 · Mar 21, 2024 · d86803d · d86803d
1 parent ddc1528
commit d86803d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/view/sfViewCacheManager.class.php b/lib/view/sfViewCacheManager.class.php
@@ -439,9 +439,11 @@ public function remove($internalUri, $hostName = '', $vary = '', $contextualPref
         if (strpos($cacheKey, '*')) {
             return $this->cache->removePattern($cacheKey);
         }
-        if ($this->cache->has($cacheKey)) {
-            return $this->cache->remove($cacheKey);
+        if (!$this->cache->has($cacheKey)) {
+            return true;
         }
+
+        return $this->cache->remove($cacheKey);
     }
 
     /**

diff --git a/lib/view/sfViewParameterHolder.class.php b/lib/view/sfViewParameterHolder.class.php
@@ -77,6 +77,8 @@ public function initialize(sfEventDispatcher $dispatcher, $parameters = [], $opt
 
         $this->setEscaping(isset($options['escaping_strategy']) ? $options['escaping_strategy'] : false);
         $this->setEscapingMethod(isset($options['escaping_method']) ? $options['escaping_method'] : 'ESC_SPECIALCHARS');
+
+        return true;
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up @@
             $this->setEscaping(isset($options['escaping_strategy']) ? $options['escaping_strategy'] : false);
             $this->setEscapingMethod(isset($options['escaping_method']) ? $options['escaping_method'] : 'ESC_SPECIALCHARS');
+            return true;
         }
         /**
@@ Expand Down @@