Fix(php-cs-fixer) Fix php-cs-fixer warnings, according to new checks

FriendsOfSymfony1 · Nov 17, 2023 · 7826e99 · 7826e99
1 parent 1ac3374
commit 7826e99
Show file tree

Hide file tree

Showing 411 changed files with 454 additions and 1,852 deletions.
diff --git a/data/bin/check_configuration.php b/data/bin/check_configuration.php
@@ -7,11 +7,6 @@ function is_cli()
 
 /**
  * Checks a configuration.
- *
- * @param mixed $boolean
- * @param mixed $message
- * @param mixed $help
- * @param mixed $fatal
  */
 function check($boolean, $message, $help = '', $fatal = false)
 {
@@ -84,8 +79,7 @@ function get_ini_path()
 $accelerator =
   (function_exists('apc_store') && ini_get('apc.enabled'))
   || function_exists('eaccelerator_put') && ini_get('eaccelerator.enable')
-  || function_exists('xcache_set')
-;
+  || function_exists('xcache_set');
 check($accelerator, 'A PHP accelerator is installed', 'Install a PHP accelerator like APC (highly recommended)', false);
 
 check(!ini_get('short_open_tag'), 'php.ini has short_open_tag set to off', 'Set it to off in php.ini', false);

diff --git a/lib/action/sfAction.class.php b/lib/action/sfAction.class.php
@@ -46,18 +46,14 @@ public function initialize($context, $moduleName, $actionName)
      *
      * By default, this method is empty.
      */
-    public function preExecute()
-    {
-    }
+    public function preExecute() {}
 
     /**
      * Execute an application defined process immediately after execution of this sfAction object.
      *
      * By default, this method is empty.
      */
-    public function postExecute()
-    {
-    }
+    public function postExecute() {}
 
     /**
      * Forwards current action to the default 404 error action.
@@ -385,8 +381,6 @@ public function setSecurityConfiguration($security)
      *
      * @param string $name    The name of the value to pull from security.yml
      * @param mixed  $default The default value to return if none is found in security.yml
-     *
-     * @return mixed
      */
     public function getSecurityValue($name, $default = null)
     {

diff --git a/lib/action/sfComponents.class.php b/lib/action/sfComponents.class.php
@@ -20,8 +20,6 @@ abstract class sfComponents extends sfComponent
     /**
      * @param sfRequest $request
      *
-     * @return mixed
-     *
      * @throws sfInitializationException
      *
      * @see sfComponent

diff --git a/lib/addon/sfPager.class.php b/lib/addon/sfPager.class.php
@@ -155,8 +155,6 @@ public function setCursor($pos)
      * Returns an object by cursor position.
      *
      * @param int $pos
-     *
-     * @return mixed
      */
     public function getObjectByCursor($pos)
     {
@@ -167,8 +165,6 @@ public function getObjectByCursor($pos)
 
     /**
      * Returns the current object.
-     *
-     * @return mixed
      */
     public function getCurrent()
     {
@@ -396,10 +392,8 @@ public function getParameterHolder()
     /**
      * Returns a parameter.
      *
-     * @param string $name
-     * @param mixed  $default
-     *
-     * @return mixed
+     * @param string     $name
+     * @param mixed|null $default
      */
     public function getParameter($name, $default = null)
     {
@@ -422,7 +416,6 @@ public function hasParameter($name)
      * Sets a parameter.
      *
      * @param string $name
-     * @param mixed  $value
      */
     public function setParameter($name, $value)
     {
@@ -525,8 +518,6 @@ public function count()
      * Used internally by {@link getCurrent()}.
      *
      * @param int $offset
-     *
-     * @return mixed
      */
     abstract protected function retrieveObject($offset);
 

diff --git a/lib/autoload/sfAutoload.class.php b/lib/autoload/sfAutoload.class.php
@@ -26,9 +26,7 @@ class sfAutoload
     protected $overriden = array();
     protected $classes = array();
 
-    protected function __construct()
-    {
-    }
+    protected function __construct() {}
 
     /**
      * Retrieves the singleton instance of this class.

diff --git a/lib/autoload/sfAutoloadAgain.class.php b/lib/autoload/sfAutoloadAgain.class.php
@@ -25,9 +25,7 @@ class sfAutoloadAgain
     /**
      * Constructor.
      */
-    protected function __construct()
-    {
-    }
+    protected function __construct() {}
 
     /**
      * Returns the singleton autoloader.

diff --git a/lib/cache/sfAPCCache.class.php b/lib/cache/sfAPCCache.class.php
@@ -27,7 +27,6 @@ class sfAPCCache extends sfCache
      * * see sfCache for options available for all drivers
      *
      * @see sfCache
-     * {@inheritdoc}
      */
     public function initialize($options = array())
     {
@@ -38,7 +37,8 @@ public function initialize($options = array())
 
     /**
      * @see sfCache
-     * {@inheritdoc}
+     *
+     * @param mixed|null $default
      */
     public function get($key, $default = null)
     {
@@ -53,7 +53,6 @@ public function get($key, $default = null)
 
     /**
      * @see sfCache
-     * {@inheritdoc}
      */
     public function has($key)
     {
@@ -68,7 +67,8 @@ public function has($key)
 
     /**
      * @see sfCache
-     * {@inheritdoc}
+     *
+     * @param mixed|null $lifetime
      */
     public function set($key, $data, $lifetime = null)
     {
@@ -81,7 +81,6 @@ public function set($key, $data, $lifetime = null)
 
     /**
      * @see sfCache
-     * {@inheritdoc}
      */
     public function remove($key)
     {
@@ -94,7 +93,6 @@ public function remove($key)
 
     /**
      * @see sfCache
-     * {@inheritdoc}
      */
     public function clean($mode = sfCache::ALL)
     {
@@ -109,7 +107,6 @@ public function clean($mode = sfCache::ALL)
 
     /**
      * @see sfCache
-     * {@inheritdoc}
      */
     public function getLastModified($key)
     {
@@ -122,7 +119,6 @@ public function getLastModified($key)
 
     /**
      * @see sfCache
-     * {@inheritdoc}
      */
     public function getTimeout($key)
     {
@@ -135,7 +131,6 @@ public function getTimeout($key)
 
     /**
      * @see sfCache
-     * {@inheritdoc}
      */
     public function removePattern($pattern)
     {

diff --git a/lib/cache/sfCache.class.php b/lib/cache/sfCache.class.php
@@ -201,8 +201,6 @@ public function getOption($name, $default = null)
      *
      * @param string $name  The option name
      * @param mixed  $value The option value
-     *
-     * @return mixed
      */
     public function setOption($name, $value)
     {

diff --git a/lib/cache/sfEAcceleratorCache.class.php b/lib/cache/sfEAcceleratorCache.class.php
@@ -42,8 +42,8 @@ public function initialize($options = array())
     /**
      * @see sfCache
      *
-     * @param string $key
-     * @param mixed  $default
+     * @param string     $key
+     * @param mixed|null $default
      *
      * @return string|null
      */
@@ -82,7 +82,6 @@ public function set($key, $data, $lifetime = null)
 
     /**
      * @see sfCache
-     * {@inheritdoc}
      */
     public function remove($key)
     {
@@ -91,7 +90,6 @@ public function remove($key)
 
     /**
      * @see sfCache
-     * {@inheritdoc}
      */
     public function removePattern($pattern)
     {
@@ -110,7 +108,6 @@ public function removePattern($pattern)
 
     /**
      * @see sfCache
-     * {@inheritdoc}
      */
     public function clean($mode = sfCache::ALL)
     {
@@ -136,7 +133,6 @@ public function clean($mode = sfCache::ALL)
 
     /**
      * @see sfCache
-     * {@inheritdoc}
      */
     public function getLastModified($key)
     {
@@ -149,7 +145,6 @@ public function getLastModified($key)
 
     /**
      * @see sfCache
-     * {@inheritdoc}
      */
     public function getTimeout($key)
     {

diff --git a/lib/cache/sfFileCache.class.php b/lib/cache/sfFileCache.class.php
@@ -33,7 +33,6 @@ class sfFileCache extends sfCache
      * * see sfCache for options available for all drivers
      *
      * @see sfCache
-     * {@inheritdoc}
      */
     public function initialize($options = array())
     {
@@ -48,7 +47,8 @@ public function initialize($options = array())
 
     /**
      * @see sfCache
-     * {@inheritdoc}
+     *
+     * @param mixed|null $default
      */
     public function get($key, $default = null)
     {
@@ -68,7 +68,6 @@ public function get($key, $default = null)
 
     /**
      * @see sfCache
-     * {@inheritdoc}
      */
     public function has($key)
     {
@@ -79,7 +78,8 @@ public function has($key)
 
     /**
      * @see sfCache
-     * {@inheritdoc}
+     *
+     * @param mixed|null $lifetime
      */
     public function set($key, $data, $lifetime = null)
     {
@@ -92,7 +92,6 @@ public function set($key, $data, $lifetime = null)
 
     /**
      * @see sfCache
-     * {@inheritdoc}
      */
     public function remove($key)
     {
@@ -101,7 +100,6 @@ public function remove($key)
 
     /**
      * @see sfCache
-     * {@inheritdoc}
      */
     public function removePattern($pattern)
     {
@@ -130,7 +128,6 @@ public function removePattern($pattern)
 
     /**
      * @see sfCache
-     * {@inheritdoc}
      */
     public function clean($mode = sfCache::ALL)
     {
@@ -150,7 +147,6 @@ public function clean($mode = sfCache::ALL)
 
     /**
      * @see sfCache
-     * {@inheritdoc}
      */
     public function getTimeout($key)
     {
@@ -167,7 +163,6 @@ public function getTimeout($key)
 
     /**
      * @see sfCache
-     * {@inheritdoc}
      */
     public function getLastModified($key)
     {