Delete: deleted XCache support, extension is not available for PHP v7.4

FriendsOfSymfony1 · Mar 13, 2024 · 64beddd · 64beddd
1 parent 019fdb6
commit 64beddd
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 242 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@ CHANGELOG
 xx/xx/xxxx: Version 1.5.xx
 --------------------------
 
+* Remove sfXCacheCache as the extension is not available on PHP v7.4 anymore.
 * Remove sfEAcceleratorCache as the extension is not available on PHP v7.4 anymore.
 * Remove sfAPCCache as it uses the `apc` extension, which is not available on PHP v7.4 anymore.
   [BC-Break] Use `sfAPCUCache` class instead, available on Symfony1 v1.5.16

diff --git a/data/bin/check_configuration.php b/data/bin/check_configuration.php
@@ -76,10 +76,8 @@ function get_ini_path()
 check(function_exists('utf8_decode'), 'The utf8_decode() is available', 'Install and enable the XML extension', false);
 check(function_exists('posix_isatty'), 'The posix_isatty() is available', 'Install and enable the php_posix extension (used to colorized the CLI output)', false);
 
-$accelerator =
-  ((function_exists('apc_store') || function_exists('apcu_store')) && ini_get('apc.enabled'))
-  || function_exists('xcache_set');
-check($accelerator, 'A PHP accelerator is installed', 'Install a PHP accelerator like APC (highly recommended)', false);
+$apcu = (function_exists('apc_store') || function_exists('apcu_store')) && ini_get('apc.enabled');
+check($apcu, 'A PHP accelerator is installed', 'Install a PHP accelerator like APCu (highly recommended)', false);
 
 check(!ini_get('short_open_tag'), 'php.ini has short_open_tag set to off', 'Set it to off in php.ini', false);
 check(!ini_get('session.auto_start'), 'php.ini has session.auto_start set to off', 'Set it to off in php.ini', false);

diff --git a/lib/autoload/sfCoreAutoload.class.php b/lib/autoload/sfCoreAutoload.class.php
@@ -48,7 +48,6 @@ class sfCoreAutoload
         'sfmemcachecache' => 'cache/sfMemcacheCache.class.php',
         'sfnocache' => 'cache/sfNoCache.class.php',
         'sfsqlitecache' => 'cache/sfSQLiteCache.class.php',
-        'sfxcachecache' => 'cache/sfXCacheCache.class.php',
         'sfansicolorformatter' => 'command/sfAnsiColorFormatter.class.php',
         'sfcommandapplication' => 'command/sfCommandApplication.class.php',
         'sfcommandargument' => 'command/sfCommandArgument.class.php',

diff --git a/lib/cache/sfXCacheCache.class.php b/lib/cache/sfXCacheCache.class.php
diff --git a/lib/debug/sfWebDebugPanelConfig.class.php b/lib/debug/sfWebDebugPanelConfig.class.php
@@ -35,12 +35,11 @@ public function getPanelContent()
             'compression' => sfConfig::get('sf_compressed') ? 'on' : 'off',
             'tokenizer' => function_exists('token_get_all') ? 'on' : 'off',
             'apc' => extension_loaded('apc') && ini_get('apc.enabled') ? 'on' : 'off',
-            'xcache' => extension_loaded('xcache') && ini_get('xcache.cacher') ? 'on' : 'off',
         );
 
         $html = '<ul id="sfWebDebugConfigSummary">';
         foreach ($config as $key => $value) {
-            $html .= '<li class="is'.$value.('xcache' == $key ? ' last' : '').'">'.$key.'</li>';
+            $html .= '<li class="is'.$value.'">'.$key.'</li>';
         }
         $html .= '</ul>';
 

diff --git a/test/unit/cache/sfXCacheCacheTest.php b/test/unit/cache/sfXCacheCacheTest.php