Skip to content

Commit

Permalink
Add: Include "test" folder to gitattribute's exclusion (#368)
Browse files Browse the repository at this point in the history
  • Loading branch information
connorhu authored Apr 4, 2024
1 parent 0c9ba11 commit 3f0adca
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@
docker-compose.yml export-ignore
phpstan.neon export-ignore
phpunit.xml export-ignore
test/ export-ignore
tests/ export-ignore

2 comments on commit 3f0adca

@JohannesTyra
Copy link

@JohannesTyra JohannesTyra commented on 3f0adca Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@connorhu with this change the autoload will fail, because this files are hardcoded in sfCoreAutoload.class.php
vendor/friendsofsymfony1/symfony1/lib/autoload/sfCoreAutoload.class.php

    'sflimeharness' => 'task/test/sfLimeHarness.class.php',
    'sftestalltask' => 'task/test/sfTestAllTask.class.php',
    'sftestbasetask' => 'task/test/sfTestBaseTask.class.php',
    'sftestcoveragetask' => 'task/test/sfTestCoverageTask.class.php',
    'sftestfunctionaltask' => 'task/test/sfTestFunctionalTask.class.php',
    'sftestplugintask' => 'task/test/sfTestPluginTask.class.php',
    'sftestunittask' => 'task/test/sfTestUnitTask.class.php',

@JohannesTyra
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its:
php symfony PHP Warning: require(/xxxx/vendor/friendsofsymfony1/symfony1/lib/task/test/sfTestPluginTask.class.php): Failed to open stream: No such file or directory in /xxxx/vendor/friendsofsymfony1/symfony1/lib/autoload/sfCoreAutoload.class.php on line 451 PHP Fatal error: Uncaught Error: Failed opening required '/xxxx/vendor/friendsofsymfony1/symfony1/lib/task/test/sfTestPluginTask.class.php' (include_path='.:/usr/share/php') in /xxxx/vendor/friendsofsymfony1/symfony1/lib/autoload/sfCoreAutoload.class.php:451 Stack trace: #0 [internal function]: sfCoreAutoload->autoload()

Please sign in to comment.