Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add(typehint) Add typehint to methods and return types #140

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Add(typehint) Add typehint to methods and return types #140

merged 1 commit into from
Jul 19, 2024

Conversation

thePanz
Copy link
Member

@thePanz thePanz commented Jun 27, 2024

No description provided.

@thePanz thePanz requested a review from connorhu June 27, 2024 14:46
@thePanz thePanz force-pushed the add-method-property-types branch from 2961835 to 5bed5ca Compare July 4, 2024 06:34
@thePanz
Copy link
Member Author

thePanz commented Jul 4, 2024 •
edited
Loading

@iricketson you might be interested in this PR as well :) WDYT?
\cc @alquerci

alquerci
alquerci reviewed Jul 4, 2024
View reviewed changes
lib/Doctrine/Migration.php Outdated Show resolved Hide resolved
alquerci
alquerci reviewed Jul 4, 2024
View reviewed changes
Copy link

@alquerci alquerci left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a pull request with intention of refactoring.

It seems to contain behaviour changes.

I cannot approve nor request changes.

@thePanz
Copy link
Member Author

thePanz commented Jul 5, 2024

For a pull request with intention of refactoring.
It seems to contain behaviour changes.

Where do you see the behavior change?

@alquerci
Copy link

alquerci commented Jul 5, 2024

For a pull request with intention of refactoring.
It seems to contain behaviour changes.

Where do you see the behavior change?

Regards to previous comments I wrote.

@thePanz thePanz force-pushed the add-method-property-types branch from 5bed5ca to ddb2fcb Compare July 19, 2024 13:49
@thePanz
Copy link
Member Author

thePanz commented Jul 19, 2024

Where do you see the behavior change?
Regards to previous comments I wrote.

Done, fixes applied now 👍
Thanks for the review

@thePanz thePanz merged commit e7bbbb0 into master Jul 19, 2024
5 checks passed
@thePanz thePanz deleted the add-method-property-types branch July 19, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alquerci alquerci alquerci left review comments

@connorhu connorhu Awaiting requested review from connorhu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thePanz @alquerci