Change dirname w/ file constants to use dir constant #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorhu
force-pushed
the
fix/dirname-file-to-dir-constant
branch
from
ec5369c to
e25888f
Compare
alquerci
approved these changes
Feb 17, 2024
connorhu
changed the title
thirsch
approved these changes
Feb 19, 2024
thePanz
force-pushed
the
fix/dirname-file-to-dir-constant
branch
from
e25888f to
5d8a53d
Compare
|
By hand 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is what it is.
In a couple of places there are conversions where I use the level argument of dirname that came in 7.0.