Add(typehint): Add typehint to methods and void return to Doctrine_Qu…

…ery_Abstract::clear()
FriendsOfSymfony1 · Oct 11, 2024 · 5c857c2 · 5c857c2
1 parent e7bbbb0
commit 5c857c2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/lib/Doctrine/Query.php b/lib/Doctrine/Query.php
@@ -187,10 +187,7 @@ public static function create($conn = null, $class = null)
         return new $class($conn);
     }
 
-    /**
-     * Clears all the sql parts.
-     */
-    protected function clear()
+    protected function clear(): void
     {
         $this->_preQueried = false;
         $this->_pendingJoinConditions = array();

diff --git a/lib/Doctrine/Query/Abstract.php b/lib/Doctrine/Query/Abstract.php
@@ -1917,10 +1917,8 @@ public function offset($offset)
 
     /**
      * Resets all the sql parts.
-     *
-     * @return void
      */
-    protected function clear()
+    protected function clear(): void
     {
         $this->_sqlParts = array(
                     'select'    => array(),

diff --git a/lib/Doctrine/RawSql.php b/lib/Doctrine/RawSql.php
@@ -57,7 +57,7 @@ function __construct(Doctrine_Connection $connection = null, Doctrine_Hydrator_A
         $this->useQueryCache(false);
     }
 
-    protected function clear()
+    protected function clear(): void
     {
         $this->_preQueried = false;
         $this->_pendingJoinConditions = array();
@@ -108,9 +108,9 @@ protected function _addDqlQueryPart($queryPartName, $queryPart, $append = false)
     /**
      * Add select parts to fields.
      *
-     * @param $queryPart sting The name of the querypart
+     * @param $queryPart string The name of the querypart
      */
-    private function _parseSelectFields($queryPart)
+    private function _parseSelectFields(string $queryPart): void
     {
         preg_match_all('/{([^}{]*)}/U', $queryPart, $m);
         $this->fields = $m[1];