Merge pull request #16 from derflocki/fix-ORA-01000

fix a possible "ORA-01000: maximum open cursors exceeded" when many n…
FriendsOfSymfony1 · May 20, 2016 · 3835027 · 3835027
2 parents 7abe498 + f50e3a3
commit 3835027
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/lib/Doctrine/Adapter/Statement/Oracle.php b/lib/Doctrine/Adapter/Statement/Oracle.php
@@ -187,7 +187,10 @@ public function bindParam($column, &$variable, $type = null, $length = null, $dr
     public function closeCursor()
     {
         $this->bindParams = array();
-        return oci_free_statement($this->statement);
+        if (is_resource($this->statement)) {
+            return oci_free_statement($this->statement);
+        }
+        return true;
     }
 
     /** 

diff --git a/lib/Doctrine/Connection/Statement.php b/lib/Doctrine/Connection/Statement.php
@@ -59,7 +59,16 @@ public function __construct(Doctrine_Connection $conn, $stmt)
             throw new Doctrine_Exception('Unknown statement object given.');
         }
     }
-
+    /**
+     * destructor
+     *
+     * make sure that the cursor is closed
+     *
+     */
+    public function __destruct()
+    {
+        $this->closeCursor();
+    }
     /**
      * getConnection
      * returns the connection object this statement uses
@@ -261,6 +270,10 @@ public function execute($params = null)
 
             $this->_conn->getListener()->postStmtExecute($event);
 
+            //fix a possible "ORA-01000: maximum open cursors exceeded" when many non-SELECTs are executed and the profiling is enabled
+            if (strtoupper(substr($this->_stmt->queryString,0,6)) != 'SELECT' && strtoupper(substr($this->_stmt->queryString,0,4)) != 'WITH' ){
+                $this->closeCursor();
+            }
             return $result;
         } catch (PDOException $e) {
         } catch (Doctrine_Adapter_Exception $e) {