Skip to content

chore: add tests for PHP 8.4 and fix deprecations #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2025
Merged

chore: add tests for PHP 8.4 and fix deprecations #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ jobs:
- 8.1
- 8.2
- 8.3
- 8.4
dependencies: [highest]

steps:
Expand Down
2 changes: 1 addition & 1 deletion src/Builder/JsonBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public function getValues(): array
return $this->values;
}

public function setValues(array $values, string $pathPrefix = null): self
public function setValues(array $values, ?string $pathPrefix = null): self
{
foreach ($values as $key => $value) {
$path = sprintf('%s[%s]', $pathPrefix, $key);
Expand Down
4 changes: 2 additions & 2 deletions src/Command/CKEditorInstallerCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,8 @@ private function info(string $message, OutputInterface $output): void
private function block(
string $message,
OutputInterface $output,
string $background = null,
string $font = null
?string $background = null,
?string $font = null
): void {
$options = [];

Expand Down
4 changes: 2 additions & 2 deletions src/Installer/CKEditorInstaller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ private function getDownloadUrl(array $options): string
/**
* @return resource
*/
private function createStreamContext(callable $notifier = null)
private function createStreamContext(?callable $notifier = null)
{
$context = [];
$proxy = getenv('https_proxy') ?: getenv('http_proxy');
Expand Down Expand Up @@ -306,7 +306,7 @@ private function extractFile(string $file, string $rewrite, string $origin, arra
}
}

private function notify(callable $notifier = null, string $type = null, mixed $data = null): mixed
private function notify(?callable $notifier = null, ?string $type = null, mixed $data = null): mixed
{
if (null !== $notifier) {
return $notifier($type, $data);
Expand Down