Flarum 2.0 update #100
Merged
Flarum 2.0 update #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsevillamartin
force-pushed
the
ds/2.0
branch
2 times, most recently
from
a493961 to
93c8ed0
Compare
Member
Author
|
I've tested Discord, GitHub, and GitLab as OAuth providers, and they worked. Not sure about the rest - iirc Twitter is really hard to test due to verifications needed on the oauth app side. |
Update dependencies to Flarum 2.0 compatible versions. # Conflicts: # js/package.json
Flarum 2.0 completely changes the JSON:API implementation
Flarum 2.0 introduces a search driver implementation and moves gambits to the frontend.
I think it mostly works. The linked accounts endpoint is scuffed - currently an include on /users/{id} -- probably should do it like fof/reactions (https://github.com/FriendsOfFlarum/reactions/pull/89/files#diff-cae97e83649b4def60e51b7ea501d84bea77b47f838d4bcf0216d757038a3ae8). I used the Fields to replace LoginProviderStatus (a bit scuffed) and the complicated list logic.
…ble unless expanded
dsevillamartin
force-pushed
the
ds/2.0
branch
from
619e277 to
b8acbfa
Compare
Member
Author
|
NOTE: Attempting to link an account that is already associated with another Flarum account currently returns a vague 500 error message. Will need to be fixed. |
…) errors Previously just showed a 500 -- icluding in debug mode! Whoops hasn't been formatting the error for some reason in 2.x
imorland
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very scuffed because it's my first dive into all the actual API changes.
This requires
fof/extendflarum req changed -- itsOAuthControllerseems to work mostly without changes though, but the extenders do need: voidaddedAPI routes are at:
ProviderResourceLIST @AddUserAttributesMade/linked-accountsendpoint(s) be/users/{id}?include=linked_accountsinsteadprobably should do/linked_accountswith a filter like reactions (https://github.com/FriendsOfFlarum/reactions/pull/89/files#diff-cae97e83649b4def60e51b7ea501d84bea77b47f838d4bcf0216d757038a3ae8)/api/linked-accounts?filter[user]=IDOther:
fieldsmethod of Resource (which replaces serializers)LabelValueis code split ([2.x] Make sure all common JS components, etc... are accessible flarum/framework#4219)